Repository navigation
Scope Doors preview browser checks to changed pages - #1278
LukasWallrich wants to merge 10 commits into
Conversation
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
✅ Spell Check PassedNo spelling issues found when checking 13 changed file(s)! 🎉 |
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/rebrand/check_design.py">
<violation number="1" location="scripts/rebrand/check_design.py:1730">
P2: The cross-page topic/facet check no longer runs when either `/` or `/resources/` changes alone, so a changed topic URL or removed facet can ship without validation. Schedule `check_directory` when either page changes and run this assertion against the unchanged counterpart as well.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| "check_conference": (CONFERENCE,), | ||
| "check_review_pages": ("publications/", "clusters/", "disciplines/", "booklet/", "community-map/"), | ||
| "check_contributor_network": (NETWORK_PATH,), | ||
| "check_directory": ("resources/",), |
There was a problem hiding this comment.
P2: The cross-page topic/facet check no longer runs when either / or /resources/ changes alone, so a changed topic URL or removed facet can ship without validation. Schedule check_directory when either page changes and run this assertion against the unchanged counterpart as well.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At scripts/rebrand/check_design.py, line 1730:
<comment>The cross-page topic/facet check no longer runs when either `/` or `/resources/` changes alone, so a changed topic URL or removed facet can ship without validation. Schedule `check_directory` when either page changes and run this assertion against the unchanged counterpart as well.</comment>
<file context>
@@ -1647,7 +1707,36 @@ def main():
+ "check_conference": (CONFERENCE,),
+ "check_review_pages": ("publications/", "clusters/", "disciplines/", "booklet/", "community-map/"),
+ "check_contributor_network": (NETWORK_PATH,),
+ "check_directory": ("resources/",),
+ }
+ if mode == "changed":
</file context>
There was a problem hiding this comment.
Note
🤖 GPT-6.2 Sol responding on behalf of Lukas Wallrich
check_directory now runs when either / or /resources/ changes and opens both pages for the topic/facet assertion.
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/rebrand-preview.yaml">
<violation number="1" location=".github/workflows/rebrand-preview.yaml:398">
P2: This selection skips browser checks when a PR changes only a static image or other non-HTML/CSS/JS visual asset. Include referenced visual assets in the comparison, or force at least the affected pages into the selection.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
View guided diff | Turn on auto-fix | Re-trigger cubic
| tar -xf base/site.tar -C base | ||
| mkdir public | ||
| tar -xf site.tar -C public | ||
| python3 scripts/rebrand/changed_pages.py base public --out changed.json | tee selection.log |
There was a problem hiding this comment.
P2: This selection skips browser checks when a PR changes only a static image or other non-HTML/CSS/JS visual asset. Include referenced visual assets in the comparison, or force at least the affected pages into the selection.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/rebrand-preview.yaml, line 398:
<comment>This selection skips browser checks when a PR changes only a static image or other non-HTML/CSS/JS visual asset. Include referenced visual assets in the comparison, or force at least the affected pages into the selection.</comment>
<file context>
@@ -388,40 +369,51 @@ jobs:
+ tar -xf base/site.tar -C base
+ mkdir public
+ tar -xf site.tar -C public
+ python3 scripts/rebrand/changed_pages.py base public --out changed.json | tee selection.log
+ else
+ python3 scripts/rebrand/changed_pages.py --full --out changed.json | tee selection.log
</file context>
There was a problem hiding this comment.
Note
🤖 GPT-6.2 Sol responding on behalf of Lukas Wallrich
Changes under static/ or to non-bundle assets under assets/ and page bundles under content/ now trigger the full browser suite.
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/README.md">
<violation number="1" location=".github/workflows/README.md:64">
P3: This summary overstates the PR-base path: pushes and full-mode PRs do not build a PR base, and those browser jobs use the full suite rather than a PR-base HTML diff. Qualify these statements to scoped same-repository PRs.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| - Compares each build with its merge base with `main`: URL list, structured data, SEO tags and internal links. See `scripts/rebrand/README.md` | ||
| - A failed check marks the run red but still updates the preview | ||
| - After the build, the comparison, the designed-screens check and the accessibility check run as three jobs side by side; the designed-screens check runs four browsers at once | ||
| - The candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content. Browser checks use the PR-base HTML diff. Changes to static files or non-bundle assets run the full browser suite. The comparison with the merge base with `main` covers the whole site. |
There was a problem hiding this comment.
P3: This summary overstates the PR-base path: pushes and full-mode PRs do not build a PR base, and those browser jobs use the full suite rather than a PR-base HTML diff. Qualify these statements to scoped same-repository PRs.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/README.md, line 64:
<comment>This summary overstates the PR-base path: pushes and full-mode PRs do not build a PR base, and those browser jobs use the full suite rather than a PR-base HTML diff. Qualify these statements to scoped same-repository PRs.</comment>
<file context>
@@ -61,7 +61,7 @@ Features:
- Compares each build with its merge base with `main`: URL list, structured data, SEO tags and internal links. See `scripts/rebrand/README.md`
- A failed check marks the run red but still updates the preview
-- PRs build their base commit alongside the candidate with the same artifacts and regenerated Contributors page. The browser checks use the resulting HTML diff. The comparison with the merge base with `main` still covers the whole site.
+- The candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content. Browser checks use the PR-base HTML diff. Changes to static files or non-bundle assets run the full browser suite. The comparison with the merge base with `main` covers the whole site.
- CSS or JS changes add the core design and axe samples to the changed-page checks. Core design covers the named screens, breakpoints, sample pages, home, floating controls at 390 and 1440 px, and every fourth article in the usual article set.
- Pushes, PRs labeled `full-checks`, PRs changing this workflow or the check scripts, and diffs over 60 pages run the full browser suite. With no relevant changes, both browser jobs report success without starting Chromium.
</file context>
| - The candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content. Browser checks use the PR-base HTML diff. Changes to static files or non-bundle assets run the full browser suite. The comparison with the merge base with `main` covers the whole site. | |
| For scoped same-repository PRs, the candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content; browser checks use the PR-base HTML diff. Full-mode runs use the full browser suite, while the comparison with the merge base with `main` covers the whole site. |
Doors preview resolves the production data and announcements artifacts from successful
mainworkflow runs. The candidate, PR base and main reference build in parallel from those pinned inputs. The Contributors page comes from the pinned data artifact. For scoped PRs, the base job reuses a successful push build at the exact base SHA when its manifest records the same artifacts and Contributors provenance. The comparison waits for both sites and checks URLs, structured data, SEO tags and internal links across the whole site.The browser checks compare rendered HTML. CSS and JS changes add the core sample and retain all changed articles, including generated articles outside that sample. Changes to either the home page or Resources run the topic/facet assertion across both pages. Pushes, check infrastructure changes, static files and non-bundle assets, the
full-checkslabel and diffs over 60 pages run the full suite.Parallel reference benchmark (UTC)
Draft #1286's Doors preview run changed one Markdown page and selected only
/replication-hub/submit/. The temporary base enabled the workflow trigger and had no reusable push build. The draft was closed and both temporary branches were deleted.The gate passed 4m 35s after the first job started. Compare with main took 1m 17s, down from 2m 27s in the earlier content-only run. Candidate build times also differed between the runs.
Local validation passed for actionlint, 209 unit tests, the Hugo build, SEO HTML, sitemap lastmod against source history, and the comparison with main using production artifacts.
Earlier job timings on 2026-11-21 (UTC)
The draft PRs targeted a temporary base branched from this head, with deployment disabled and only the branch triggers changed. All three reused the same successful push build. In the previous cold runs the base job took 4m 32s for content and 5m 36s for CSS. With reuse it took 22–24s, and the browser jobs started as soon as the candidate was ready.
All three Doors checks passed. The content trial selected only the edited educators-corner page. The CSS trial selected core mode with zero changed HTML pages and 46 article pages. The mixed trial retained the core sections, added the edited article to the article set for 47 pages, and ran its call-out and phone-reading sections. The initial CSS fixture did not change the emitted bundle, so the table uses the corrected stylesheet-token trials. All three drafts were closed and their branches and the temporary base removed.
Earlier workflow totals, including queueing
Implemented with GPT-6.2 Sol in Codex.