Skip to content

Temporary Doors CI benchmark (CSS) - #1284

Closed
LukasWallrich wants to merge 2 commits into
scratch-1278-basefrom
scratch-1278-css
Closed

LukasWallrich wants to merge 2 commits into
scratch-1278-basefrom
scratch-1278-css

Conversation

@LukasWallrich

@LukasWallrich LukasWallrich commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Measures scoped browser checks and base artifact reuse for #1278.


Summary by cubic

Temporary benchmark PR for #1278: changes the --page color token in assets/css/doors/tokens.css, a token emitted in the Doors CSS bundle, to verify that the CI pipeline runs scoped browser checks and reuses base artifacts correctly.

Written for commit f564a7b. Summary will update on new commits.

View guided diff Turn on auto-fix

@LukasWallrich
LukasWallrich requested a review from a team as a code owner November 21, 2026 13:10
@LukasWallrich
LukasWallrich marked this pull request as draft November 21, 2026 13:10
@github-actions

Copy link
Copy Markdown
Contributor

👍 All image files/references (if any) are in webp format, in line with our policy.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="assets/scss/custom.scss">

<violation number="1" location="assets/scss/custom.scss:466">
P2: This color change never reaches the Doors cluster UI. `on_theme` disables the compiled `custom.scss` bundle, while cluster pages load `assets/css/doors/clusters.css`, which still defines `#004055`; change the loaded Doors stylesheet instead.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread assets/scss/custom.scss Outdated
}
.acc-header:hover { color: #333; }
.acc-header--rec { color: #004055; }
.acc-header--rec { color: #004056; }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This color change never reaches the Doors cluster UI. on_theme disables the compiled custom.scss bundle, while cluster pages load assets/css/doors/clusters.css, which still defines #004055; change the loaded Doors stylesheet instead.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At assets/scss/custom.scss, line 466:

<comment>This color change never reaches the Doors cluster UI. `on_theme` disables the compiled `custom.scss` bundle, while cluster pages load `assets/css/doors/clusters.css`, which still defines `#004055`; change the loaded Doors stylesheet instead.</comment>

<file context>
@@ -463,7 +463,7 @@
 }
 .acc-header:hover { color: #333; }
-.acc-header--rec { color: #004055; }
+.acc-header--rec { color: #004056; }
 .acc-header--rec:hover { color: #00556e; }
 .acc-header.acc-disabled {
</file context>

@github-actions

Copy link
Copy Markdown
Contributor

✅ Spell Check Passed

No spell-checkable files were changed in this PR.

@LukasWallrich
LukasWallrich deleted the scratch-1278-css branch November 21, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant