Repository navigation
Temporary Doors CI benchmark (CSS) - #1284
Closed
LukasWallrich wants to merge 2 commits into
Closed
LukasWallrich wants to merge 2 commits into
LukasWallrich wants to merge 2 commits into
Conversation
LukasWallrich
marked this pull request as draft
November 21, 2026 13:10
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="assets/scss/custom.scss">
<violation number="1" location="assets/scss/custom.scss:466">
P2: This color change never reaches the Doors cluster UI. `on_theme` disables the compiled `custom.scss` bundle, while cluster pages load `assets/css/doors/clusters.css`, which still defines `#004055`; change the loaded Doors stylesheet instead.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| } | ||
| .acc-header:hover { color: #333; } | ||
| .acc-header--rec { color: #004055; } | ||
| .acc-header--rec { color: #004056; } |
Contributor
There was a problem hiding this comment.
P2: This color change never reaches the Doors cluster UI. on_theme disables the compiled custom.scss bundle, while cluster pages load assets/css/doors/clusters.css, which still defines #004055; change the loaded Doors stylesheet instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At assets/scss/custom.scss, line 466:
<comment>This color change never reaches the Doors cluster UI. `on_theme` disables the compiled `custom.scss` bundle, while cluster pages load `assets/css/doors/clusters.css`, which still defines `#004055`; change the loaded Doors stylesheet instead.</comment>
<file context>
@@ -463,7 +463,7 @@
}
.acc-header:hover { color: #333; }
-.acc-header--rec { color: #004055; }
+.acc-header--rec { color: #004056; }
.acc-header--rec:hover { color: #00556e; }
.acc-header.acc-disabled {
</file context>
Contributor
✅ Spell Check PassedNo spell-checkable files were changed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measures scoped browser checks and base artifact reuse for #1278.
Summary by cubic
Temporary benchmark PR for #1278: changes the
--pagecolor token inassets/css/doors/tokens.css, a token emitted in the Doors CSS bundle, to verify that the CI pipeline runs scoped browser checks and reuses base artifacts correctly.Written for commit f564a7b. Summary will update on new commits.