Repository navigation
Temporary Doors CI trial (content) - #1279
LukasWallrich wants to merge 2 commits into
Conversation
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
✅ Spell Check PassedNo spelling issues found when checking 7 changed file(s)! 🎉 |
There was a problem hiding this comment.
3 issues found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/rebrand/check_axe.py">
<violation number="1" location="scripts/rebrand/check_axe.py:79">
P2: This comprehension reintroduces `/404.html` after `sample.pop("404", None)` explicitly excluded it. A PR changing the 404 output will now run axe against that redirect page and can fail the scoped check; retain the exclusion.</violation>
</file>
<file name=".github/workflows/rebrand-preview.yaml">
<violation number="1" location=".github/workflows/rebrand-preview.yaml:73">
P2: Workflow and check-script changes do not force the full browser suite: `BASE_SHA` is assigned but never used, so ordinary PRs remain scoped unless they carry `full-checks` or are pushes. Compare the PR base with `HEAD` for the workflow and check-script paths before setting `scoped=true`.</violation>
</file>
<file name="scripts/rebrand/check_design.py">
<violation number="1" location="scripts/rebrand/check_design.py:1073">
P2: The changed-page filter disables the home/resources consistency assertion for every single-route change. Trigger this check when either participating route changes and allow it to compare the changed route with the other page.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| sample.pop("404", None) | ||
| if mode == "changed": | ||
| names = {path: name for name, path in sample.items()} | ||
| sample = {names.get(path, path): path for path in sorted(pages)} |
There was a problem hiding this comment.
P2: This comprehension reintroduces /404.html after sample.pop("404", None) explicitly excluded it. A PR changing the 404 output will now run axe against that redirect page and can fail the scoped check; retain the exclusion.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At scripts/rebrand/check_axe.py, line 79:
<comment>This comprehension reintroduces `/404.html` after `sample.pop("404", None)` explicitly excluded it. A PR changing the 404 output will now run axe against that redirect page and can fail the scoped check; retain the exclusion.</comment>
<file context>
@@ -57,14 +59,24 @@ def main():
sample.pop("404", None)
+ if mode == "changed":
+ names = {path: name for name, path in sample.items()}
+ sample = {names.get(path, path): path for path in sorted(pages)}
with open(args.axe, encoding="utf-8") as handle:
axe = handle.read()
</file context>
| sample = {names.get(path, path): path for path in sorted(pages)} | |
| sample = {names.get(path, path): path for path in sorted(pages) if path != "/404.html"} |
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | ||
| FULL_LABEL: ${{ contains(github.event.pull_request.labels.*.name, 'full-checks') }} | ||
| run: | | ||
| if [ "$EVENT" != pull_request ] || [ "$FULL_LABEL" = true ]; then |
There was a problem hiding this comment.
P2: Workflow and check-script changes do not force the full browser suite: BASE_SHA is assigned but never used, so ordinary PRs remain scoped unless they carry full-checks or are pushes. Compare the PR base with HEAD for the workflow and check-script paths before setting scoped=true.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/rebrand-preview.yaml, line 73:
<comment>Workflow and check-script changes do not force the full browser suite: `BASE_SHA` is assigned but never used, so ordinary PRs remain scoped unless they carry `full-checks` or are pushes. Compare the PR base with `HEAD` for the workflow and check-script paths before setting `scoped=true`.</comment>
<file context>
@@ -58,6 +63,19 @@ jobs:
+ BASE_SHA: ${{ github.event.pull_request.base.sha }}
+ FULL_LABEL: ${{ contains(github.event.pull_request.labels.*.name, 'full-checks') }}
+ run: |
+ if [ "$EVENT" != pull_request ] || [ "$FULL_LABEL" = true ]; then
+ echo "scoped=false" >> "$GITHUB_OUTPUT"
+ else
</file context>
| if [ "$EVENT" != pull_request ] || [ "$FULL_LABEL" = true ]; then | |
| if [ "$EVENT" != pull_request ] || [ "$FULL_LABEL" = true ] || | |
| ! git diff --quiet "$BASE_SHA" HEAD -- .github/workflows/rebrand-preview.yaml scripts/rebrand; then |
| known = topics.evaluate("[...document.querySelectorAll('.facet[data-facet=cluster] .chip')].map(c => c.dataset.value)") | ||
| expect(wanted and set(wanted) <= set(known), f"every topic button names a real cluster: {sorted(set(wanted) - set(known))}") | ||
| topics.context.close() | ||
| if selected is None or {"/", "/resources/"} <= selected: |
There was a problem hiding this comment.
P2: The changed-page filter disables the home/resources consistency assertion for every single-route change. Trigger this check when either participating route changes and allow it to compare the changed route with the other page.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At scripts/rebrand/check_design.py, line 1073:
<comment>The changed-page filter disables the home/resources consistency assertion for every single-route change. Trigger this check when either participating route changes and allow it to compare the changed route with the other page.</comment>
<file context>
@@ -970,75 +997,87 @@ def look(state, selector="#just-os-bubble", floating=False):
- known = topics.evaluate("[...document.querySelectorAll('.facet[data-facet=cluster] .chip')].map(c => c.dataset.value)")
- expect(wanted and set(wanted) <= set(known), f"every topic button names a real cluster: {sorted(set(wanted) - set(known))}")
- topics.context.close()
+ if selected is None or {"/", "/resources/"} <= selected:
+ topics = new_page(browser, 1440)
+ topics.goto(base, wait_until="load")
</file context>
Timing trial for #1278. This draft bypasses the infrastructure-change trigger to exercise changed-page checks against rebrand-doors. It will be closed after CI.
Summary by cubic
Scopes the Doors preview's browser checks to changed pages, cutting run time on small PRs. This is a timing trial for the changed-page checks and will be closed after CI.
full-checkslabel, workflow or script changes, or diffs over 60 pages run the full suite.changed_pages.pywith tests for page selection and HTML normalization.Written for commit 10acec3. Summary will update on new commits.