Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ Features:
- Uses the same data and announcement artifacts as `deploy.yaml`, with noindex and no analytics
- Compares each build with its merge base with `main`: URL list, structured data, SEO tags and internal links. See `scripts/rebrand/README.md`
- A failed check marks the run red but still updates the preview
- After the build, the comparison, the designed-screens check and the accessibility check run as three jobs side by side; the designed-screens check runs four browsers at once
- The candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content. Browser checks use the PR-base HTML diff. Changes to static files or non-bundle assets run the full browser suite. The comparison with the merge base with `main` covers the whole site.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This summary overstates the PR-base path: pushes and full-mode PRs do not build a PR base, and those browser jobs use the full suite rather than a PR-base HTML diff. Qualify these statements to scoped same-repository PRs.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/README.md, line 64:

<comment>This summary overstates the PR-base path: pushes and full-mode PRs do not build a PR base, and those browser jobs use the full suite rather than a PR-base HTML diff. Qualify these statements to scoped same-repository PRs.</comment>

<file context>
@@ -61,7 +61,7 @@ Features:
 - Compares each build with its merge base with `main`: URL list, structured data, SEO tags and internal links. See `scripts/rebrand/README.md`
 - A failed check marks the run red but still updates the preview
-- PRs build their base commit alongside the candidate with the same artifacts and regenerated Contributors page. The browser checks use the resulting HTML diff. The comparison with the merge base with `main` still covers the whole site.
+- The candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content. Browser checks use the PR-base HTML diff. Changes to static files or non-bundle assets run the full browser suite. The comparison with the merge base with `main` covers the whole site.
 - CSS or JS changes add the core design and axe samples to the changed-page checks. Core design covers the named screens, breakpoints, sample pages, home, floating controls at 390 and 1440 px, and every fourth article in the usual article set.
 - Pushes, PRs labeled `full-checks`, PRs changing this workflow or the check scripts, and diffs over 60 pages run the full browser suite. With no relevant changes, both browser jobs report success without starting Chromium.
</file context>
Suggested change
- The candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content. Browser checks use the PR-base HTML diff. Changes to static files or non-bundle assets run the full browser suite. The comparison with the merge base with `main` covers the whole site.
For scoped same-repository PRs, the candidate, PR base and main reference build in parallel from the same pinned production artifacts, including generated Contributors content; browser checks use the PR-base HTML diff. Full-mode runs use the full browser suite, while the comparison with the merge base with `main` covers the whole site.

- CSS or JS changes add the core design and axe samples to the changed-page checks. Core design covers the named screens, breakpoints, sample pages, home, floating controls at 390 and 1440 px, and every fourth article in the usual article set.
- Pushes, PRs labeled `full-checks`, PRs changing this workflow or the check scripts, and diffs over 60 pages run the full browser suite. With no relevant changes, both browser jobs report success without starting Chromium.
- Design and axe cache Chromium by Playwright version.
- Delete this workflow when the redesign launches

## Data Workflows
Expand Down
Loading
Loading