Repository navigation
Conversation
rclcpp deprecates subscription callbacks that take std::shared_ptr<MessageT>. Clang reports the deprecation through the template instantiation from create_subscription(), although the rclcpp headers are system headers, so grid_map_visualization and grid_map_demos do not build with -Werror. GCC does not report it. The three callbacks only read the message, so they can take std::shared_ptr<const MessageT>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenCV 5 removed the C constants CV_BGR2GRAY, CV_BGRA2GRAY and CV_BGRA2RGB, so GridMapCvConverter.hpp does not compile with it. conda-forge ships OpenCV 5, and RoboStack carries this change as a patch for Lyrical. The cv::COLOR_* constants also exist in OpenCV 3 and 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tests declare two Eigen::Array2i variables that they never use. With Eigen 5, Clang reports them with -Wunused-variable, and the test does not build with -Werror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 14, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three small fixes for toolchains that the Ubuntu CI does not cover. With #551, #552 and #553,
grid_mapbuilds and passes its tests on Lyrical with Ubuntu 26.04. These commits make it build with Clang, Eigen 5 and OpenCV 5 too, for example with the RoboStack (conda-forge) packages on macOS.fix: take ConstSharedPtr in the subscription callbacks: rclcpp deprecates subscription callbacks that takestd::shared_ptr<MessageT>. Clang reports the deprecation through the template instantiation fromcreate_subscription(), although the rclcpp headers are system headers, sogrid_map_visualizationandgrid_map_demosfail with-Werror. GCC does not report it. The three callbacks only read the message.fix(grid_map_cv): use the cv::COLOR_* constants: OpenCV 5 removedCV_BGR2GRAY,CV_BGRA2GRAYandCV_BGRA2RGB. Thecv::COLOR_*constants also exist in OpenCV 3 and 4. RoboStack carries this change as a patch.test(grid_map_core): remove unused variables in SubmapIteratorTest: with Eigen 5, Clang reports two unusedEigen::Array2ivariables with-Wunused-variable.None of them changes the behavior.
How it was tested
colcon buildbuilds all 15 packages, andcolcon testgives841 tests, 0 errors, 0 failures, 195 skipped. Without each commit, the package that it fixes does not build.🤖 Generated with Claude Code