Repository navigation
fix: take ConstSharedPtr in the subscription callbacks - #557
Merged
Merged
Conversation
rclcpp deprecates subscription callbacks that take std::shared_ptr<MessageT>. Clang reports the deprecation through the template instantiation from create_subscription(), although the rclcpp headers are system headers, so grid_map_visualization and grid_map_demos do not build with -Werror. GCC does not report it. The three callbacks only read the message, so they can take std::shared_ptr<const MessageT>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Take
ConstSharedPtrin the three subscription callbacks ofgrid_map_visualizationandgrid_map_demos. Split from #556.Why
rclcpp deprecates subscription callbacks that take
std::shared_ptr<MessageT>. Clang reports the deprecation through the template instantiation fromcreate_subscription(), although the rclcpp headers are system headers, so both packages do not build with-Werror:GCC does not report it, so the Ubuntu CI passes without this change. The callbacks only read the message.
How it was tested
grid_map_visualizationandgrid_map_demosdo not build.🤖 Generated with Claude Code