Repository navigation
fix(grid_map_cv): use the cv::COLOR_* constants - #558
Merged
Merged
Conversation
OpenCV 5 removed the C constants CV_BGR2GRAY, CV_BGRA2GRAY and CV_BGRA2RGB, so GridMapCvConverter.hpp does not compile with it. conda-forge ships OpenCV 5, and RoboStack carries this change as a patch for Lyrical. The cv::COLOR_* constants also exist in OpenCV 3 and 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use
cv::COLOR_BGR2GRAY,cv::COLOR_BGRA2GRAYandcv::COLOR_BGRA2RGBinGridMapCvConverter.hpp. Split from #556.Why
OpenCV 5 removed the C constants
CV_BGR2GRAY,CV_BGRA2GRAYandCV_BGRA2RGB, sogrid_map_cvand every package that includesGridMapCvConverter.hppdo not build with it:conda-forge ships OpenCV 5, and RoboStack carries this change as a patch. The
cv::COLOR_*constants also exist in OpenCV 3 and 4.How it was tested
grid_map_cvdoes not build.🤖 Generated with Claude Code