Repository navigation
test(grid_map_core): remove unused variables in SubmapIteratorTest - #559
Merged
wep21 merged 1 commit intoNov 14, 2026
Merged
Conversation
The tests declare two Eigen::Array2i variables that they never use. With Eigen 5, Clang reports them with -Wunused-variable, and the test does not build with -Werror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the variables
indexandsubmapIndexfrom the two tests inSubmapIteratorTest.cpp. The tests declare them but never use them. Split from #556.Why
With Eigen 5, Clang reports them with
-Wunused-variable, so the tests ofgrid_map_coredo not build with-Werror:Only builds with tests are affected.
How it was tested
grid_map_coredo not build. With it, they build and pass.🤖 Generated with Claude Code