Skip to content

Fix the install_requires test that stopped matching urllib3 once it had a version bound #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendancol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the install_requires test that stopped matching urllib3 once it had a version bound #3769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xrspatial/geotiff/tests/integration/test_http_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2168,7 +2168,7 @@ def test_install_requires_lists_urllib3():
if line and not line.startswith((' ', '\t')):
break
block_lines.append(line.strip())
assert 'urllib3' in block_lines, (
assert any(line.split()[0] == 'urllib3' for line in block_lines if line), (
f"urllib3 must be in install_requires; found: {block_lines}"
)

Expand Down
Loading