Repository navigation
Fix the install_requires test that stopped matching urllib3 once it had a version bound - #3769
Open
brendancol wants to merge 1 commit into
Open
brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
brendancol
commented
Nov 6, 2026
brendancol
left a comment
Contributor
Author
There was a problem hiding this comment.
PR Review: Fix the install_requires test that stopped matching urllib3 once it had a version bound
One-line test change. Checked the surrounding code and the history.
Blockers (must fix before merge)
- None.
Suggestions (should fix, not blocking)
- None.
Nits (optional improvements)
-
xrspatial/geotiff/tests/integration/test_http_sources.py:2158: the test skips whensetup.cfgis not next to the package, which is why CI (non-editable install) never saw the failure. If the guard is meant to be a real gate, the skip could become a failure on CI, but that is a separate decision.
What looks good
- Comparing the first whitespace-separated token keeps the test's intent (urllib3 is declared) while allowing any version specifier, which is what #3702 introduced.
- Passes locally against the current
urllib3 >=2.7line.
Checklist
- Algorithm matches reference/paper (n/a)
- All implemented backends produce consistent results (n/a)
- NaN handling is correct (n/a)
- Edge cases are covered by tests (n/a)
- Dask chunk boundaries handled correctly (n/a)
- No premature materialization or unnecessary copies (n/a)
- Benchmark exists or is not needed
- README feature matrix updated (n/a)
- Docstrings present and accurate
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_install_requires_lists_urllib3asserts the literal stringurllib3is one of theinstall_requireslines. Since #3702 the line isurllib3 >=2.7, so the test fails on main whenever the integration directory is collected. It compares the first token now.Found while running the full geotiff suite locally for #3768.
Test plan:
pytest xrspatial/geotiff/tests/integration/test_http_sources.py -k test_install_requires_lists_urllib3passes locally