Repository navigation
chore: record Android 3.1.1 release - #1904
piotr-iohk wants to merge 1 commit into
Conversation
[Low impact] This release-recording change appears safe to merge. SummaryRecords the shipped Android 3.1.1 build 197 on
No actionable issues found. Reviews (1) · Last reviewed commit: "chore: record Android 3.1.1 release" · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Records the shipped 3.1.1 (build 197) on master: version fields, the 3.1.1 changelog section and compare links, and removal of the four fragments it consumed. Reviewed 0443ae5, full tier, static (Bitkit Android branches are not built here; reasoned from the diff, the v3.1.1 tag and CI).
What I checked, and 3 candidates I ruled out
Against the tag: CHANGELOG.md on the PR head is byte-identical to CHANGELOG.md at v3.1.1; versionCode = 197 and versionName = "3.1.1" match the tag's app/build.gradle.kts.
Base: the merge base is the current master tip (db3b1b2), so nothing on master is overwritten.
Ruled out
- A consumed fragment left behind, so 3.1.1 entries repeat in the next release: the four entries with fragments on
master(#1798, #1801, #1803, #1870) are the four deleted; #1824 and #1873 never had a fragment onmaster. A keyword pass over the 26 remaining fragments matched none of the 3.1.1 entries (the two "Lightning node" hits, #1536 and #1756, are different fixes). - An unreleased fragment deleted by mistake: only the four above are removed.
- Compare links:
[Unreleased]now starts atv3.1.1and[3.1.1]spansv3.1.0...v3.1.1, consistent with the existing entries.
CI: Greptile passed; build-and-test, lint, build-local and compose-ui were pending when this was posted.
Merge confidence: 4/5, the change is version fields and changelog only, but CI was still running at review time.
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
There was a problem hiding this comment.
Verdict: 💬 Comment. The release record matches published v3.1.1; current-head Compose UI CI is failing.
Findings: None.
QA for 0443ae5:
Check: Match the published release ✅ Static comparison confirms version 3.1.1, build 197, and the published changelog.
CHANGELOG.md is byte-identical to the published tag, which points to 0f23fc2. The Gradle version fields also match that tag.
Check: Preserve unreleased changelog entries ✅ Static inspection confirms the four deleted fragments are recorded in 3.1.1 and the remaining entries are preserved.
Each of the four deleted fragments appears verbatim in the published changelog. The 26 remaining fragments describe other changes. The release comparison links are correct, and git diff --check passes for db3b1b2..0443ae5.
Check: Current-head CI ⚠️ Builds, unit tests, lint and local E2E pass, but Compose UI has eight failures.
The Compose UI job reports six window-focus failures and two Compose timeouts. Its failure also fails the aggregate build check; the build-and-test job itself passed. Lint and local E2E also passed. I have not reproduced the Compose failures against the base or established that this PR causes them.
No app build or device cases were run for this review: the QA notes list static checks, and this diff only records release metadata and consumes changelog fragments. The linked release QA spreadsheet required authentication, so I did not use it as evidence. The earlier review at this head agrees with the independently checked release-record comparisons.
Full review covered all six changed files in db3b1b2..0443ae5. No runtime or test sources changed.
Twin: bitkit-ios#1319 chore: record iOS 3.1.1 release matches this release-record scope, using iOS build 204 and its platform-specific changelog entries.
Reviewed by gpt-6.1-sol-high
Description
Record the shipped Bitkit 3.1.1 build 197 on
master. Copy the published changelog and remove the fragments already included in it so the next release does not repeat those entries. Published 3.1.1 release · Release PRDesign
N/A — no UI changes.
Preview
N/A
QA Notes
Compared the Gradle version fields and changelog with the published
v3.1.1tag.git diff --checkpassed. Mainnet QA covers the shipped tag. 3.1.1 QA resultsModels used
GPT-6(reasoning:Not exposed)GPT-6(reasoning:Not exposed)The session exposes the model family. The reasoning setting is unavailable.