Skip to content

chore: use 3.1.1 migration baselines - #311

Open
piotr-iohk wants to merge 2 commits into
mainfrom
codex/migration-baseline-3.1.1
Open

piotr-iohk wants to merge 2 commits into
mainfrom
codex/migration-baseline-3.1.1

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Future Android and iOS migration runs should start from the shipped 3.1.1 native release. Advance both defaults to 3.1.1 and record the SHA-256 digests of the archived regtest APK and iOS simulator ZIP. Keep historical checksums and React Native v1.1.6 coverage.

  • All nine migration helper tests passed.
  • Both migration matrices select 3.1.1 for native restore and upgrade, with v1.1.6 for both RN cases.

Hosted validation uses this PR's default pins and the standard RN cases. The targets are the 3.1.1 version-bump branches because both current masters still build 3.1.0.

Land the native version bumps before switching the default baseline so scheduled migration runs have compatible install-over targets.

  • Android passed all four routine cases. Both native jobs used the published 3.1.1 APK and verified its SHA-256.
  • iOS passed all four routine cases by workflow attempt 2. Both native jobs used the corrected public 3.1.1 simulator ZIP and verified its SHA-256. The initial ZIP used a lowercase bundle root, which the downloader rejected before running tests.
  • The iOS RN upgrade passed on retry against the same app and E2E revisions. The first run included an Appium session timeout, a wallet backup prompt covering the wallet, and a Spending Balance Error. The successful retry establishes intermittent behavior for this case. The cause of the Spending Balance Error remains undetermined.

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Moves the Android and iOS native migration baselines from 3.1.0 to 3.1.1 and records the 3.1.1 archive digests. Reviewed 61fa986, light tier.

What I checked, and 3 candidates I ruled out

Read in full: config/migration-baselines.json, config/migration-checksums.json, and their readers scripts/migration-matrix.py (migration_plan) and scripts/download-migration-app.py (download)
CI: this repo runs no checks on the branch. The two hosted migration runs linked in the body were still in_progress when I looked.
Not run: talos-pr-run could not confirm the author's permission on this repo, so I did not execute the branch; this review is static plus the asset checks below. Both JSON files parse.

Ruled out

  • Digest mismatch: both new values equal GitHub's own digest for bitkit_e2e.apk and Bitkit.app.zip on the 3.1.1 release, and the release's SHA256SUMS.txt.
  • Asset name or tag drift: download() fetches releases/download/<version>/<asset> with the asset names bitkit_e2e.apk and Bitkit.app.zip, and looks up checksums[<version>][<asset>]; the new 3.1.1 key and both asset names match the release.
  • Helper tests pinned to the old baseline: test_migration_tools.py writes its own fixture baselines since #299, so the bump needs no test change.

Merge confidence: 4/5, a config value checked against the release, but the hosted migration runs it cites had not finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants