Skip to content

fix(config): keep @solidjs/start out of server pre-bundling #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brenelz merged 1 commit into from
Nov 13, 2026
Merged

fix(config): keep @solidjs/start out of server pre-bundling #2380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/exclude-start-from-server-prebundling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Keep `@solidjs/start` out of server pre-bundling, so that server functions no longer fail with "invalid server function" in dev with plugins that pre-bundle server dependencies, such as the Cloudflare Vite plugin.
6 changes: 6 additions & 0 deletions packages/start/src/config/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@ describe("resolve conditions", () => {
expect(ssr.resolve.conditions).not.toContain("node");
});

it("keeps @solidjs/start out of the server's pre-bundled dependencies", async () => {
const { ssr } = await resolveEnvironments();

expect(ssr.optimizeDeps.exclude).toContain("@solidjs/start");
});

it("pre-bundles the dev overlay's dependencies in dev only", async () => {
const dev = await resolveEnvironments("serve");
const build = await resolveEnvironments("build");
Expand Down
3 changes: 3 additions & 0 deletions packages/start/src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,9 @@ export function solidStart(options?: SolidStartOptions): Array<PluginOption> {
},
[VITE_ENVIRONMENTS.server]: {
consumer: "server",
// Plugins that pre-bundle server dependencies, such as the Cloudflare Vite plugin,
// would otherwise load a second copy of the server function registry
optimizeDeps: { exclude: ["@solidjs/start"] },
build: {
ssr: true,
write: true,
Expand Down
Loading