Repository navigation
fix(config): keep @solidjs/start out of server pre-bundling - #2380
Merged
Merged
Conversation
SolidStart's server runtime keeps state in its modules, such as the server function registry. A deployment plugin that pre-bundles server dependencies in dev (the Cloudflare Vite plugin does, since it runs the server in workerd) loaded a second copy of them, so server function calls failed with "invalid server function".
🦋 Changeset detectedLatest commit: 72bdb29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy request for solid-start-landing-page pending review.Visit the deploys page to approve it
|
commit: |
lxsmnsyc
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
In dev, plugins that pre-bundle server dependencies, such as the Cloudflare Vite plugin, end up with two copies of SolidStart's server function registry. Routes register their functions in one and the handler looks them up in the other, so calling a server function fails with
invalid server function: <id>.What is the new behavior?
The server environment keeps
@solidjs/startout of pre-bundling, so server functions work in dev with these plugins. Environments that don't pre-bundle server dependencies, such as Nitro's, are unaffected.Other information
To reproduce without Cloudflare, add
environments: { ssr: { optimizeDeps: { noDiscovery: false } } }to the basic template's Vite config and a button that calls a"use server"function, then click it invite dev.