Skip to content

Stellar WriteReport: return the earliest failed transmission hash for a failed transmission - #923

Merged
ilija42 merged 8 commits into
mainfrom
stellar-write-report-failed-canonical-hash
Nov 18, 2026
Merged

ilija42 merged 8 commits into
mainfrom
stellar-write-report-failed-canonical-hash

Conversation

@ilija42

@ilija42 ilija42 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem

After a submit, when the forwarder state is Failed, a node returned its own tx hash if its own transaction landed.

The forwarder allows a retry after Failed, so more than one node can land a failed transaction for the same report. Each of those nodes then returned a different hash, and the workflow DON could miss F+1 identical replies.

InvalidReceiver does not have this problem. It is terminal in the forwarder: a second report is rejected with AlreadyProcessed, so only one transaction can record it.

Change

  • Failed after submit: always return the earliest failed transmission hash from the forwarder events, never the local hash.

@ilija42
ilija42 marked this pull request as ready for review November 18, 2026 13:24
@ilija42
ilija42 requested review from a team as code owners November 18, 2026 13:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T13:24:56.565105Z 4d4f36c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Base automatically changed from stellar-write-report-peer-landed-on-submit-error to main November 18, 2026 14:26
@ilija42
ilija42 enabled auto-merge November 18, 2026 14:32
@ilija42
ilija42 requested a review from dhaidashenko November 18, 2026 15:42
@ilija42
ilija42 added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 47fcd09 Nov 18, 2026
18 checks passed
@ilija42
ilija42 deleted the stellar-write-report-failed-canonical-hash branch November 18, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants