Repository navigation
Stellar WriteReport: return the earliest failed transmission hash for a failed transmission - #923
Merged
Merged
Conversation
…fter a peer already landed the report
…imulation fails after a peer already landed the report
…port recorded transmission reply
…teReport so all nodes agree on the tx hash
ilija42
marked this pull request as ready for review
November 18, 2026 13:24
product-security-plaid-production
Bot
requested review from
Unheilbar,
patrickhuie19 and
silaslenihan
November 18, 2026 13:24
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
stellar-write-report-peer-landed-on-submit-error
to
main
November 18, 2026 14:26
ilija42
enabled auto-merge
November 18, 2026 14:32
yashnevatia
approved these changes
Nov 18, 2026
dhaidashenko
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a submit, when the forwarder state is
Failed, a node returned its own tx hash if its own transaction landed.The forwarder allows a retry after
Failed, so more than one node can land a failed transaction for the same report. Each of those nodes then returned a different hash, and the workflow DON could miss F+1 identical replies.InvalidReceiverdoes not have this problem. It is terminal in the forwarder: a second report is rejected withAlreadyProcessed, so only one transaction can record it.Change
Failedafter submit: always return the earliest failed transmission hash from the forwarder events, never the local hash.