Repository navigation
[PLEX-3523] - Stellar WriteReport: return the on-chain outcome when simulation or submit fails after a peer landed the report - #917
Conversation
…fter a peer already landed the report
|
👋 ilija42, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…imulation fails after a peer already landed the report
| return nil, capabilities.ResponseMetadata{}, err | ||
| } | ||
| return reply, wr.meteringFromReply(reply), nil | ||
| case TransmissionStateFailed, TransmissionStateInvalidReceiver: |
There was a problem hiding this comment.
Is it not possible for two nodes to get a transaction on-chain with invalid receiver/failed status?
If so, won't returning the local tx hash cause a workflow failure, since we might not get F+1 identical hashes, or different WF nodes might resume with different hashes?
There was a problem hiding this comment.
Its hard for this to cause an issue since we only retry if the previous node in the transmission schedule didn't transmit on time. That said this dos seem like a bug that slipped through the cracks in the inital implementation, made a followup here
#923
…port recorded transmission reply
Problem
When a peer's transmission lands while this node is simulating or submitting, the forwarder rejects this node's report with
AlreadyProcessed(Error(Contract, #13)). The capability then returns an error although the report is on chain. There are two paths:submit transaction: pipeline failure. This is counted as a WriteReport error.receiver cannot accept the report). This is logged but not counted.=