Repository navigation
Return block timestamp in EVM WriteReportReply - #916
Merged
Merged
Conversation
This was referenced Nov 17, 2026
Krish-vemula
force-pushed
the
feat/evm-write-report-block-timestamp
branch
from
November 18, 2026 22:48
28323b7 to
23e2dc0
Compare
Krish-vemula
marked this pull request as ready for review
November 18, 2026 22:54
product-security-plaid-production
Bot
requested review from
amit-momin,
kalverra and
prashantkumar1982
November 18, 2026 22:54
amit-momin
reviewed
Nov 20, 2026
amit-momin
reviewed
Nov 20, 2026
amit-momin
previously approved these changes
Nov 20, 2026
jmank88
previously approved these changes
Nov 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2026
Krish-vemula
enabled auto-merge
November 20, 2026 23:38
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2026
Krish-vemula
dismissed stale reviews from jmank88 and amit-momin
via
November 21, 2026 00:05
815d619
jmank88
approved these changes
Nov 21, 2026
Unheilbar
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EVM
WriteReportnow fills inWriteReportReply.block_timestamp(microseconds), matching Aptos and Stellar, for SLO tx-latency tracking.How
replyFromReceipt, so the change is made once there.HeaderByNumber(receipt.BlockNumber)(withWithQuickRetry) and returnheader.Timestamp * 1_000_000.FeatureEVMWriteReportBlockTimestampActivePeriod, checked against the execution timestamp. This is the same pattern as the L1 fee flag and the Aptos block timestamp flag.Behaviour
WithQuickRetryas the receipt/fee lookups. If it still fails, or the receipt has no block number, the reply fails with an error, so nodes never reply without the field (keeps the remote F+1 identical-response quorum intact).revertReplyBuildErrorwrapping, so the revert reason is still surfaced.Testing
TestReplyFromReceiptBlockTimestamp(table-driven) covers: flag on/off, success and revert, header error, empty header, zero timestamp, missing block number, hash mismatch.TestReplyFromReceiptBlockTimestamp_NilLimiterOmitsTimestampTestWriteReportBlockTimestamp_FeatureFlagWiringruns the fullEVM.WriteReportflow with the limiter built from cresettings defaults.go test ./... -racepasses andgolangci-lintreports 0 issues (run against local chainlink-common).Dependencies
chain_capabilities/evm/go.modonce it merges.Rollout
Set
FeatureEVMWriteReportBlockTimestampActivePeriodin CRE settings for each environment to enable.