Skip to content

relocatable.py test: take the C extension's include directories from sysconfig #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itamaro merged 1 commit into from
Nov 6, 2026
Merged

relocatable.py test: take the C extension's include directories from sysconfig #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions relocatability.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,9 +769,14 @@ def _check_venv(self) -> str:
def _check_c_extension(self) -> str:
if self.snapshot is None:
raise CheckSkipped("the startup probe did not complete")
config = self._python_config()
includes = self._run([config, "--includes"])
self._require_success(includes, "python-config --includes failed")
# Ask sysconfig, as build tools do. python-config's output can't
# be split into arguments when the path contains spaces.
paths = self.snapshot.get("config_paths") or {}
includes = [
f"-I{paths[name]}" for name in ("include", "platinclude") if paths.get(name)
]
if not includes:
raise CheckFailed("sysconfig did not provide the include directories")
ldshared = self.snapshot.get("ldshared")
ext_suffix = self.snapshot.get("ext_suffix")
if not isinstance(ldshared, str) or not ldshared:
Expand Down Expand Up @@ -824,7 +829,7 @@ def _check_c_extension(self) -> str:
*shlex.split(ldshared),
# e.g. -fPIC on Linux; LDSHARED doesn't include it.
*shlex.split(self.snapshot.get("ccshared") or ""),
*shlex.split(includes.stdout),
*includes,
os.fspath(source),
"-o",
os.fspath(extension),
Expand Down
Loading