Repository navigation
relocatable.py test: take the C extension's include directories from sysconfig - #42
Merged
Merged
Conversation
itamaro
force-pushed
the
relocatability-c-extension-includes
branch
from
November 5, 2026 18:06
27e53c1 to
d47a25a
Compare
`developer.c-extension` split `python-config --includes` into arguments, which can't work when the installation path contains spaces, as the relocated tree's does. That made the check fail on Linux, and on macOS it repeated `developer.python-config`'s stale shebang failure without compiling anything. Use the moved interpreter's `sysconfig.get_paths()` instead, as build tools do; `developer.python-config` still checks python-config itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
itamaro
force-pushed
the
relocatability-c-extension-includes
branch
from
November 6, 2026 02:09
d47a25a to
6fa302b
Compare
itamaro
marked this pull request as ready for review
November 6, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developer.c-extensiongot its include flags by splitting the output ofpython-config --includesinto arguments. That can't work when the installation path contains spaces, and the moved tree's path deliberately does.python-configprints the right path, but unquoted, and no output format works for every consumer, so this isn't a relocatability bug in CPython. As a result:Python.h: No such file or directory.developer.python-config's stale-shebang error without compiling anything, so the same problem was counted twice.This takes the include directories from the moved interpreter's
sysconfig.get_paths(), the way build tools do, and passes each one as a single argument.developer.python-configstill checkspython-configitself. The staleINCLUDEPYandCONFINCLUDEPYconfig variables are still reported byruntime.paths.developer.c-extensionnow compiles and imports the extension on both platforms.Written with assistance from Claude Opus 5.5