Skip to content

gh-160334: Accept special frames in collapsed profiling test #161515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raman118 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

gh-160334: Accept special frames in collapsed profiling test #161515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b91316a
gh-160334: Accept special frames in collapsed profiling test
raman118 Nov 6, 2026
b5f7aaf
gh-160334: Add NEWS entry
raman118 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/test/test_profiling/test_sampling_profiler/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,10 @@ def test_sampling_with_collapsed_export(self):
if ";" in stack_trace:
stack_parts = stack_trace.split(";")
for part in stack_parts:
# Each part should be file:function:line
# Special frames, such as <GC> and unreadable frames,
# do not have file and line information.
if part.startswith("<") and part.endswith(">"):
continue
self.assertIn(":", part)

def test_sampling_all_threads(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-11-07-01-45-00.gh-issue-160334.F2n8qA.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix the sampling profiler integration test for special frames without file and
line information.
Loading