Repository navigation
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-160334.
Collapsed profiling output uses bare special-frame names such as
<GC>and<unreadable frame>when no file or line information is available. Update the integration test to accept that established format instead of requiring every stack part to contain a colon.The current assertion fails deterministically for a collector fed an unreadable frame; the focused test and the full sampling-profiler integration module pass with this change.
Tests:
PCbuild\\build.bat -d -p x64 -M -qPCbuild\\amd64\\python_d.exe -m test -v -m test_sampling_with_collapsed_export test_profiling.test_sampling_profiler.test_integrationPCbuild\\amd64\\python_d.exe -m test -v test_profiling.test_sampling_profiler.test_integration(21 passed, 1 skipped)PCbuild\\amd64\\python_d.exe Tools\\patchcheck\\patchcheck.pyAI assistance was used to investigate the test failure and prepare this change. I reviewed the collector output and the test results before opening this PR.