Skip to content

Add DataChannelRpcConnectionClosed (1506) RPC error code #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1egoman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add DataChannelRpcConnectionClosed (1506) RPC error code #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rpc-connection-closed-error-code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@livekit/protocol": patch
---

Add the `DataChannelRpcConnectionClosed` (1506, "Connection closed") data channel RPC error code, used by the client SDKs when the caller's own room disconnects while a call is in flight
4 changes: 4 additions & 0 deletions utils/data_channel_rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const (
DataChannelRpcRecipientDisconnected
DataChannelRpcResponsePayloadTooLarge
DataChannelRpcSendFailed
DataChannelRpcConnectionClosed
)

const (
Expand All @@ -41,6 +42,7 @@ var dataChannelRpcErrorMessages = map[DataChannelRpcErrorCode]string{
DataChannelRpcRecipientDisconnected: "Recipient disconnected",
DataChannelRpcResponsePayloadTooLarge: "Response payload too large",
DataChannelRpcSendFailed: "Failed to send",
DataChannelRpcConnectionClosed: "Connection closed",

DataChannelRpcUnsupportedMethod: "Method not supported at destination",
DataChannelRpcRecipientNotFound: "Recipient not found",
Expand Down Expand Up @@ -76,6 +78,8 @@ func (e *DataChannelRpcError) PsrpcError() psrpc.Error {
return psrpc.NewError(psrpc.MalformedResponse, e)
case DataChannelRpcSendFailed:
return psrpc.NewError(psrpc.Internal, e)
case DataChannelRpcConnectionClosed:
return psrpc.NewError(psrpc.Unavailable, e)
case DataChannelRpcUnsupportedMethod:
return psrpc.NewError(psrpc.InvalidArgument, e)
case DataChannelRpcRecipientNotFound:
Expand Down
Loading