Repository navigation
Conversation
Mirrors CONNECTION_CLOSED from the JS SDK (livekit/client-sdk-js#2251) and ConnectionClosed from the Rust SDK (livekit/rust-sdks#1671): a call fails with it when the caller's own room disconnects while the call is in flight.
🦋 Changeset detectedLatest commit: 5e8c041 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
boks1971
approved these changes
Nov 13, 2026
ladvoc
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the built-in data channel RPC error code
DataChannelRpcConnectionClosed= 1506, message "Connection closed", toutils/data_channel_rpc.go.The client SDKs recently added this code. A pending
performRpccall fails with it when the caller's own room disconnects mid-call. That keeps it separate fromRecipientDisconnected(1503), which means the remote participant left.CONNECTION_CLOSED)RpcErrorCode::ConnectionClosed)I compared the full code list against both SDKs. 1506 is the only one missing here; every other code and message already matches.
Change
DataChannelRpcConnectionClosedto the1500 + iotablock (so it's 1506) and its message todataChannelRpcErrorMessages.psrpc.UnavailableinPsrpcError(), the same asRecipientDisconnected. Without a case it would fall through toInternal.Checked locally: the constant is 1506,
Error()givesRpcError 1506: Connection closed, andPsrpcError().Code()isunavailable.🤖 Generated with Claude Code