Skip to content

Import pyplot explicitly before closing figures in show() #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
raisingchris2026 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Import pyplot explicitly before closing figures in show() #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb04a6
Add test: show() closes figures when matplotlib has no pyplot attribu…
raisingchris2026 Nov 6, 2026
30f5f7e
Import pyplot explicitly before closing figures in show() (fixes #24)
raisingchris2026 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion matplotlib_inline/backend_inline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ def show(close=None, block=None):
# only call close('all') if any to close
# close triggers gc.collect, which can be slow
if close and Gcf.get_all_fig_managers():
matplotlib.pyplot.close("all")
from matplotlib import pyplot

pyplot.close("all")


# This flag will be reset by draw_if_interactive when called
Expand Down
14 changes: 14 additions & 0 deletions tests/test_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,17 @@ def test_import():
from matplotlib_inline.backend_inline import show

show()


def test_show_closes_figures_without_pyplot_attribute(monkeypatch):
# gh-24: lazy loaders (e.g. librosa < 0.10.1) can leave matplotlib.pyplot
# in sys.modules without setting it as an attribute of matplotlib.
import matplotlib
import matplotlib.pyplot as plt

from matplotlib_inline.backend_inline import show

plt.figure()
monkeypatch.delattr(matplotlib, "pyplot")
show(close=True)
assert plt.get_fignums() == []