Repository navigation
Conversation
Remove invalid date suffixes from Sonnet and Opus; verify actual SDK model payloads with local fixtures. Generated-with: gpt-6.1-sol
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
|
Independent functional review by GPT-6/Codex, separate session 01a160ec-8a99-7c83-b6e9-01276265c6a8, exact head 4bef7f2. Read the full three-file diff, model enum, SDK initialization/request construction and both model-selection test modules in an isolated checkout. No blocking functional finding in this bounded model-ID correction. The proposed Sonnet/Opus IDs match Anthropic's current primary documentation: https://platform.claude.com/docs/en/about-claude/models/model-ids-and-versions . Haiku remains unchanged. Local Windows/Python 3.12.10, pytest 9.1.1: all three SDK-payload tests and all five existing offscreen panel-selection tests passed; Ruff on the added test and git diff --check passed. A negative control executes the same mocked-SDK assertions against unchanged current-master service source: Sonnet/default and Opus fail, Haiku passes. No real provider requests, credentials or visible-window acceptance; no new full-suite run claimed. Merge-HOLD, two concrete blockers:
Please retain version 1.0.3 and obtain fresh exact-head CI/review after resolving these items. No ready/merge action, branch rewrite, integration commit, runtime mirror update or deployment was performed. |
lukisch
left a comment
There was a problem hiding this comment.
Zweitprüfung (Cloud-Bot): inhaltlich freigegeben, Konflikt in #13 aufgelöst.
- Die Korrektur ist richtig:
claude-sonnet-4-6undclaude-opus-4-6sind die gültigen Kennungen. Die bisherigen Werte mit-20250514gibt es nicht. - Head
4bef7f2steht weiter im Konflikt mitmaster(f2f3894), und zwar nur inCHANGELOG.md. - #13 enthält denselben Commit auf dem aktuellen
master, mit dem ursprünglichen Autor und beiden Changelog-Abschnitten. Lokal unter Python 3.12 mit PySide6 6.8.2.1: 293 passed,ruff check .sauber. - Der DCO-Hinweis aus dem vorigen Review bleibt offen. Ich habe keine
Signed-off-by-Zeile ergänzt.
Vorschlag: #9 schließen, sobald #13 gemergt ist. An diesem Branch habe ich nichts geändert.
Generated by Claude Code
The AI assistant sends
claude-sonnet-4-6-20250514by default andclaude-opus-4-6-20250514when Opus is selected. These identifiers mix the 4.6 generation with an older snapshot date. Anthropic documents the canonical IDs asclaude-sonnet-4-6andclaude-opus-4-6.Correct those two enum values. Keep Haiku 4.5 and the surrounding request behavior unchanged. Add three fixture-only regressions that exercise AIService.complete and inspect the actual SDK model/message payload for the default, Opus and Haiku selections. Record the correction under Unreleased; no product version change.
Primary reference: https://platform.claude.com/docs/en/about-claude/models/model-ids-and-versions
Validation on Windows Python 3.12 / pytest 9.1.1:
Author model: gpt-6.1-sol (Codex). Draft pending independent review; merges disabled. Based directly on master 49d7a83, independent of the action-upgrade PR #8. Canonical worktree and OneDrive deployment stay on their existing states until reviewed integration.