Repository navigation
Conversation
Integrates #9 (4bef7f2) on current master. The only conflict was CHANGELOG.md; both sections are kept. The Sonnet and Opus enum values mixed the 4.6 generation with an older snapshot date. They now use claude-sonnet-4-6 and claude-opus-4-6. Haiku 4.5 is unchanged. Three fixture-only tests check the model ID that reaches the SDK. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F17eZ5jWcC9snC7oi1
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
lukisch
commented
Nov 11, 2026
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Zweitprüfung (Cloud-Bot) – Head 00469ba
Hinweis: Der PR stammt aus einem früheren Bot-Lauf (claude/…-Branch, gleiche GitHub-Identität). Das ist keine unabhängige Prüfung und keine formale Freigabe.
Ergebnis: freigabefähig, keine funktionalen Befunde.
- Diff geprüft (3 Dateien, +51/−2): nur die beiden Enum-Werte in
src/modules/ai_assistant/ai_service.py:17-18, der neue Test und der CHANGELOG-Eintrag. tests/test_ai_model_ids.py: lokal 3 bestanden (Python 3.12). Gegenprobe mit demai_service.pyvonmaster: 2 von 3 schlagen fehl. Die Tests greifen also.ruff check .: sauber.- Gesamtsuite lokal nur teilweise lauffähig: 206 bestanden, die übrigen Qt-Tests scheitern hier an fehlendem
libEGL.so.1(Container, kein Codefehler). Maßgeblich sind die grünen CI-Jobstest (3.11)undtest (3.12). - Nicht verifiziert: echte API-Anfrage mit den neuen Modellkennungen.
Nicht blockierend:
src/core/settings_manager.py:57enthält weiter den Defaultclaude-sonnet-4-20250514. Er erreicht das SDK nicht (src/gui/main_window.py:1251-1258bildet nur Anzeigenamen ab), sollte aber in einem Folge-PR bereinigt werden.- Der
Signed-off-by-Trailer lautCONTRIBUTING.mdfehlt. Entscheidung beim Maintainer.
Nicht gemergt; die Freigabe liegt beim Maintainer.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AI assistant sends
claude-sonnet-4-6-20250514by default andclaude-opus-4-6-20250514when Opus is selected. These IDs do not exist: they combine the 4.6 generation with the snapshot date of an older model. A request with either one is rejected by the API, so the assistant only works with Haiku selected.#9 fixed this on 2026-10-15 and was reviewed without functional findings, but it has conflicted with
mastersince then.Changes
This is the commit from #9 (
4bef7f2) cherry-picked onto the currentmaster(f2f3894), original author kept.AIModel.CLAUDE_SONNETis nowclaude-sonnet-4-6,AIModel.CLAUDE_OPUSisclaude-opus-4-6. Haiku 4.5 is unchanged.tests/test_ai_model_ids.py: three fixture-only tests check the model ID and message payload that reach the SDK. No real API request.CHANGELOG.mdwas the only conflict. Both the store-packaging section and the model-ID section are kept.Verification
Python 3.12, PySide6 6.8.2.1,
QT_QPA_PLATFORM=offscreen:masterplus the three new tests).ruff check .: clean.Notes for the reviewer
CONTRIBUTING.mdasks for aSigned-off-bytrailer. I did not add one, because that certification belongs to the author. The recent commits onmasterdo not carry one either.tests/test_cli_and_logging.py::test_cli_licenses_summary_and_exportfails on unmodifiedmasterin an environment withoutpipin the interpreter (for example auvvenv): the license list is empty, the JSON export still succeeds, andgenerate_notice_filereturnsFalse. It passes oncepipis installed. Not touched here.src/core/settings_manager.pystill defaultsmodeltoclaude-sonnet-4-20250514. I found no code path that sends this value to the SDK, so I left it alone.Generated by Claude Code