Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux test jobs can report every assertion passing and then crash with exit 139 during interpreter shutdown. A captured native backtrace and core identify PyQt cleanup visiting a stale SIP wrapper-map bucket after the map has been rebuilt.
Require
PyQt5-sip>=12.20.1,<13and update only that package in the lockfile (12.17.0 → 12.20.1). The upstream fix snapshots wrappers before visiting them and checks that each still exists. See the upstream release notes.Three subprocess regression cases exercise a Qt
destroyedcallback that replaces wrapped objects during shutdown. All three crash with the old runtime and pass with 12.20.1. They import QtCore only and verify normal process exit and callback execution. No Phy GUI or curation logic changes.Local validation:
master, Python 3.12:make test-fullpasses (635 core + 168 application tests; 19 skipped), exit 0; includes lint and formatting.master, Python 3.11: full CI test command passes (803 tests; 19 skipped), exit 0.make doc-checkanduv buildpass; wheel metadata contains the new lower bound.This is a standalone fix against
master; #1428 remains unchanged. Once this is merged, that branch can incorporate the updated dependency. No CI workflow changes or failure suppression are included.