Skip to content

Require PyQt5-sip 12.20.1 to fix Qt shutdown crashes - #1442

Open
rossant wants to merge 1 commit into
masterfrom
fix/pyqt5-sip-shutdown
Open

rossant wants to merge 1 commit into
masterfrom
fix/pyqt5-sip-shutdown

Conversation

@rossant

@rossant rossant commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Linux test jobs can report every assertion passing and then crash with exit 139 during interpreter shutdown. A captured native backtrace and core identify PyQt cleanup visiting a stale SIP wrapper-map bucket after the map has been rebuilt.

Require PyQt5-sip>=12.20.1,<13 and update only that package in the lockfile (12.17.0 → 12.20.1). The upstream fix snapshots wrappers before visiting them and checks that each still exists. See the upstream release notes.

Three subprocess regression cases exercise a Qt destroyed callback that replaces wrapped objects during shutdown. All three crash with the old runtime and pass with 12.20.1. They import QtCore only and verify normal process exit and callback execution. No Phy GUI or curation logic changes.

Local validation:

  • master, Python 3.12: make test-full passes (635 core + 168 application tests; 19 skipped), exit 0; includes lint and formatting.
  • master, Python 3.11: full CI test command passes (803 tests; 19 skipped), exit 0.
  • Support bounded curation and full-source replay for long recordings #1428 head with this dependency update and regression cases: full suite passes (1,480 tests; 19 skipped), exit 0.
  • Python 3.10: Qt-only 4,096-object reproducer exits normally with the fixed runtime.
  • make doc-check and uv build pass; wheel metadata contains the new lower bound.

This is a standalone fix against master; #1428 remains unchanged. Once this is merged, that branch can incorporate the updated dependency. No CI workflow changes or failure suppression are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant