Repository navigation
Conversation
Contributor
Author
|
Implemented the latest feedback:
Validated ordinary and bounded real-data workflows, 706 core + 833 application tests, and independent checks of every assignment in two 469.7-million-spike full-source replays. Additional focused regressions cover legacy identities and rollback display state. CI was excluded. |
# Conflicts: # docs/changelog.md # docs/clustering.md # phy/cluster/supervisor.py # phy/cluster/tests/test_supervisor.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curate long recordings using bounded shared-window evidence, then replay saved decisions against every source spike into a new full sorting. The source stays unchanged.
1+2→100, then100+3→101, restores equivalents of 1,2,3 together. Later unrelated edits remain intact; one Undo reverses the whole restoration. Fresh IDs preserve unambiguous history and original identities appear in Parent.Updated narrated 58-second, 30 fps demonstration · User guide · Restoration guide · Validation, screenshots and media provenance
Local evidence: both copied real-data walkthroughs passed all 12 checkpoints, including recursive membership, later-edit preservation, exact green SLAY status, one Undo, Save/reopen and unchanged-source hashes. 706 core + 833 application tests passed, 19 skipped, with normal exits; final followups passed 147 ordinary integration tests and 122 Supervisor tests, including rollback-cache failure recovery. Lint, formatting, docs and source/wheel builds pass. Validation uses PyQt5-sip 12.20.1, proposed separately in #1442 for the diagnosed upstream shutdown bug; this branch's lockfile remains unchanged. CI is excluded.
Independent original-label/raw-amplitude verification checked all 469,725,567 assignments in each of two full-source replays (one/four workers), following an amplitude split, two nested merges, recursive restoration, exclusion/addition/remerge and later unrelated edits. All 45 metadata fields / 31,545 cells, counts, reviews, lineage and cumulative provenance survive replay/reprepare. All 140 input files retain hashes and stats. The scientific run is attributed to
03377575; subsequent UI-only proof changes are separately hashed/AST-checked and tested. The final ordinary alias and rollback-display fixes have focused regressions.Still draft: focused user testing remains. Restoration stops at genuine split or unknown ancestry boundaries; corrupt known ancestry or any missing retained leaf evidence rejects before mutation. New version-4 recursive events preserve the existing version-3 immediate-parent replay meaning. Historical restoration across a fresh preparation remains unavailable; restored live children replay/reprepare normally. Read-only comparison remains limited to 16 immediate parents. Arbitrary bounded lasso/feature splits remain outside scope. The converted fixture's clock/exposure provenance is unverified; this is engineering validation, and the newer 5.24-billion-spike recording is unavailable locally. The event-class guard addresses the logged exception path without establishing the cause of every instability.