Repository navigation
Add githubCodeOwners.format.align and spacing - #44
Merged
Merged
Conversation
Setting it to legacy asks the gh-codeowners language server to line up the first owner of every rule, offset by githubCodeOwners.format.alignmentOffset, which is no longer deprecated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
Match gh-codeowners' fmt --align group|file and --spacing. The deprecated alignmentOffset settings still apply, as spacing one more than the offset, until spacing is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
VS Code's own AI actions can answer first, so the test sometimes saw only those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
It reads the format settings this extension sends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
chdsbd
marked this pull request as ready for review
November 10, 2026 12:50
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new formatting option (
file) to match legacy behavior.🤖 Adds settings for how the gh-codeowners language server formats CODEOWNERS, including the pre-5.1.0 formatting, and bundles gh-codeowners v0.4.0, which supports them.
githubCodeOwners.format.align:group(the default, the current behavior) orfile(one column for the whole file, like before 5.1.0).githubCodeOwners.format.spacing: the number of spaces between the longest pattern and the owners. It defaults to 1. To format exactly like before 5.1.0, usealign: filewithspacing: 5.githubCodeOwners.format.alignmentOffsetandgithub-code-owners.format.alignment-offsetare deprecated again, now pointing tospacing. If the user set one of them and hasn't setspacing, the extension sendsoffset + 1, so their files format as before.format.enabledexplains how to get the old formatting.{ format: { align, spacing } }asinitializationOptions, and sendsworkspace/didChangeConfigurationwhen any of these settings change, so no restart is needed.s/download-serverbundles gh-codeowners v0.4.0 (Add --align and --spacing to fmt and the language server gh-codeowners#43), which reads these settings.spacingoverriding it.Verification
npm run typecheck,npm run eslint,npm run fmt:checkandnpm run compilepass.--align file --spacing 3.