Repository navigation
Build packages into a draft release, and publish them when it's published - #46
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
The draft's notes are the version's CHANGELOG.md section. Publishing it creates the tag and runs publish.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
Use its s/release-notes, skip versions that already have a tag, don't let two pushes draft at once, and document releasing in CONTRIBUTING.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
draft-release.yml builds a VSIX package for each platform and only drafts the release once s/check-packages finds all of them attached, deleting a draft that's missing any. publish.yml publishes the release's packages to the Marketplace, after checking they're all there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM
chdsbd
marked this pull request as ready for review
November 10, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 When
masterhas a version with no release yet, GitHub Actions builds a VSIX package for each platform and drafts a release with them. Publishing the draft publishes exactly those packages to the Marketplace.Drafting (
draft-release.yml, on pushes tomaster)package.json. It stops if thev<version>tag already exists, or if a release (draft or published) already uses it. That covers pushes without a version bump and reruns. v5.2.0 is already published, so merging this PR creates nothing.contents: read, sonpm ciruns without write access):s/package-alldownloads each platform's gh-codeowners and runsvsce package --targetfor 8 platforms plus the universal package, then checks they're all there.contents: write): creates a draftv<version>on the pushed commit with all the packages attached and the version'sCHANGELOG.mdsection as notes (s/release-notes, the same script as gh-codeowners). Then it reads back the draft's assets.A
concurrencygroup keeps two quick pushes from both drafting.Making sure every package is there
s/packagesis the only list of what a release needs: 9 packages, named likegithub-code-owners-5.3.0-darwin-arm64.vsix.s/check-packagesfails unless a set of files or asset names matches it exactly, nothing missing and nothing extra. It runs:gh release create. If that fails, or the upload fails partway, the workflow deletes the draft, so a draft only ever exists with every package. Deleting it also lets the next push or a re-run try again.publish.yml, on the published release's assets before anything goes to the Marketplace. A release you published without them, like one created by hand, fails here with nothing published.Publishing (
publish.yml, on release published)Downloads the release's
.vsixfiles, checks them, and runsvsce publish --oidc --packagePath dist/*.vsixin a single job. It no longer rebuilds or re-downloads gh-codeowners, so the Marketplace gets the same files that are attached to the release.Publishing the draft stays manual, because a release published with
GITHUB_TOKENwouldn't triggerpublish.yml, and the tag ruleset only lets admins createv*tags.Verification
s/package-all 5.2.0built all 9 packages locally, withs/download-serverstubbed to copy a local gh-codeowners binary, sincegh release downloadis blocked in my environment. Each platform's manifest has itsTargetPlatformand abin/binary; the universal package has neither.s/check-packagespasses for the full set and for bare asset names, and fails, showing the difference, for a missing package or an extra file.gh: it succeeds with every package; ifgh release createfails or the draft is missing a package, it deletes the draft and fails.upload-artifactv7.0.2 anddownload-artifactv8.0.2 are pinned to the commits their tags point to.🤖 Generated with Claude Code
https://claude.ai/code/session_018s9fHcEQxmXZ7pQ6v9W2KM