Repository navigation
stop_sandbox stops the CI k8s sandbox in every region, whatever labels the PR has (ENG-227126) - #41
Merged
Merged
Conversation
…l (ENG-227126) stop_sandbox sent the sandbox.yml stop only together with removing a `sandbox` label it found in the event payload. A sandbox can be running with no label (removed by hand after its start was asked for), and the payload's labels are the PR's when the run is created, not when the comment was posted, so such a sandbox could not be stopped and ran to its time limit. The US stop is now sent on every stop_sandbox; the label is still removed when present, and regional stops stay tied to their labels. The launcher's stop is idempotent, so a stop with nothing running does nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GodBYdczeSv48XzK3eeCzj
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
…r label found The per-label regional stops had the same gap as the US one: a regional sandbox whose label was gone, or not in the event's labels, was never stopped. One dispatch with sandbox.yml's region `all` stops the PR's sandbox wherever it runs. Labels found are still removed. Needs the vscode sandbox.yml that accepts `all` on master first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GodBYdczeSv48XzK3eeCzj
sbijarnia-eightfold
approved these changes
Nov 20, 2026
asheth-eightfold
added a commit
that referenced
this pull request
Nov 20, 2026
Conflicts in entrypoint.sh against #39 (start on needs_sandbox also when the label is on) and #41 (stop_sandbox stops every region). Took master's structure and added dev to it: - needs_sandbox:dev picks `sandbox 🧪` / region dev in master's wanted_label chain, so it gets #39's behaviour too; - stop_sandbox removes `sandbox 🧪`; master's `stop all` already stops dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stop_sandboxsent asandbox.ymlstop only for each sandbox label it found in the event payload, one stop per labelled region. A sandbox can be running with its label gone, and then no stop is sent at all: no reply, and the sandbox runs to its time limit. This happens in two ways:Fix
On
stop_sandbox:region: all, whatever labels were found.sandbox.ymlstops the PR's sandbox in every region with a CI k8s cluster; a region with nothing running is left as it is.needs_sandboxis unchanged.Merge order
Merge only after the vscode change that adds
alltosandbox.yml's region input is on master. Until thensandbox.ymlrejectsall(HTTP 422) andstop_sandboxwould stop nothing. Rollback: revert this PR first.Test
Ran
entrypoint.shlocally with a stubbedcurland synthetic events:stop_sandbox, no sandbox labelallstop_sandbox,sandboxsandbox; stopallstop_sandbox,sandbox :eu:+sandbox :australia:+sandbox :united_arab_emirates:allstop_sandbox,sandbox:3.13allstop_sandbox,SANDBOX_K8S_TRIGGERoffsandboxonlyneeds_sandbox:eusandbox :eu:; starteu(unchanged)needs_sandboxwithsandboxon🤖 Generated with Claude Code
https://claude.ai/code/session_01GodBYdczeSv48XzK3eeCzj