Repository navigation
needs_ci_dev and needs_sandbox:dev: CI k8s in the dev region, dev-us (ENG-226579) - #40
Merged
Merged
Conversation
… dev account (ENG-226579) - needs_ci_dev, needs_ci_dev:lite: add the label and start ci_k8s_full_dev.yml / ci_k8s_lite_dev.yml (vscode), which run the suite pods in the dev region's account and remove the label when they finish. - needs_sandbox:dev: `sandbox :test_tube:` and sandbox.yml region=dev. `dev` moves from the hours group to the region group: until now `needs_sandbox:dev` matched the hours group and started a us-west-2 sandbox. - stop_sandbox stops the dev sandbox too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… dev The dev runs are now a job of the existing CI k8s workflows (vscode#125595), not files of their own. ci_k8s_request takes an optional account; a prod request's payload is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The vscode workflows (vscode#125595) take the EF region the run happens in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asheth-eightfold
marked this pull request as ready for review
November 20, 2026 12:00
Conflicts in entrypoint.sh against #39 (start on needs_sandbox also when the label is on) and #41 (stop_sandbox stops every region). Took master's structure and added dev to it: - needs_sandbox:dev picks `sandbox 🧪` / region dev in master's wanted_label chain, so it gets #39's behaviour too; - stop_sandbox removes `sandbox 🧪`; master's `stop all` already stops dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment side of running CI k8s in the dev region, EF region
dev-us(its own account, 304104589360). Companion to EightfoldAI/vscode#125595, ENG-226579. Merge after vscode#125595: this action is used@master, and its dev dispatches pass anef_regioninput that vscode's workflows only declare once that PR is on master.needs_ci_devneeds_ci_dev, dispatchesci_k8s_full.ymlwithef_region: dev-usneeds_ci_dev:liteneeds_ci_dev:lite, dispatchesci_k8s_lite.ymlwithef_region: dev-usneeds_sandbox:dev[:<hours>[:<apps>]]devas an hours token and started a us-west-2 sandbox (sandbox)sandbox :test_tube:, dispatchessandbox.ymlregion=devstop_sandboxsandbox :test_tube:; the dev sandbox is stopped by master'sstop all(#41), which includesdevci_k8s_request/sandbox_k8s_request(gated byCI_K8S_TRIGGER/SANDBOX_K8S_TRIGGER). A label added with GITHUB_TOKEN starts no workflow, as forneeds_ci.needs_ci_devhas no fleet side and noci_verifiedto reset. The dev run removes its own label when it finishes.Test plan
entrypoint.shrun locally against a fakecurlthat records each API call, for this branch andmaster:bash -n entrypoint.shpasses.Payloads (stub
curl): prod requests are unchanged,{"ref":"master","inputs":{"pr":"N"}}. Dev requests add"ef_region":"dev-us". GitHub rejects an input the workflow onmasterdoesn't declare (422), so merge after vscode#125595.Merged with master (2026-11-20): resolved conflicts with #39 (start on
needs_sandboxalso when the label is on) and #41 (stop_sandboxstops every region).needs_sandbox:devnow goes through master'swanted_label/regionchain, so it gets #39's behaviour too. Re-checked the routing with the file's own regex and chain:needs_sandbox:dev,e2e_needs_sandbox:devandneeds_sandbox:dev:4→sandbox :test_tube:/region=dev;needs_sandbox,:eu,:apunchanged. On master,needs_sandbox:dev→sandbox/ us, as seen on vscode#125932.🤖 Generated with Claude Code