Skip to content

needs_ci_dev and needs_sandbox:dev: CI k8s in the dev region, dev-us (ENG-226579) - #40

Merged
asheth-eightfold merged 4 commits into
masterfrom
asheth/eng-226579-dev-account
Nov 20, 2026
Merged

asheth-eightfold merged 4 commits into
masterfrom
asheth/eng-226579-dev-account

Conversation

@asheth-eightfold

@asheth-eightfold asheth-eightfold commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The comment side of running CI k8s in the dev region, EF region dev-us (its own account, 304104589360). Companion to EightfoldAI/vscode#125595, ENG-226579. Merge after vscode#125595: this action is used @master, and its dev dispatches pass an ef_region input that vscode's workflows only declare once that PR is on master.

Comment Before After
needs_ci_dev nothing adds needs_ci_dev, dispatches ci_k8s_full.yml with ef_region: dev-us
needs_ci_dev:lite nothing adds needs_ci_dev:lite, dispatches ci_k8s_lite.yml with ef_region: dev-us
needs_sandbox:dev[:<hours>[:<apps>]] ⚠️ matched dev as an hours token and started a us-west-2 sandbox (sandbox) adds sandbox :test_tube:, dispatches sandbox.yml region=dev
stop_sandbox — also removes sandbox :test_tube:; the dev sandbox is stopped by master's stop all (#41), which includes dev
  • Dispatches go through the existing ci_k8s_request / sandbox_k8s_request (gated by CI_K8S_TRIGGER / SANDBOX_K8S_TRIGGER). A label added with GITHUB_TOKEN starts no workflow, as for needs_ci.
  • needs_ci_dev has no fleet side and no ci_verified to reset. The dev run removes its own label when it finishes.
  • The alternate-Python sandbox branch is unchanged.

Test plan

entrypoint.sh run locally against a fake curl that records each API call, for this branch and master:

needs_ci_dev                    NEW: POST labels ["needs_ci_dev"] + dispatch ci_k8s_full.yml {"pr","ef_region":"dev-us"}   OLD: nothing
needs_ci_dev:lite               NEW: POST labels ["needs_ci_dev:lite"] + dispatch ci_k8s_lite.yml {"pr","ef_region":"dev-us"} OLD: nothing
needs_ci_dev (label present)    NEW: nothing                                                                OLD: nothing
needs_sandbox:dev               NEW: ["sandbox :test_tube:"] + sandbox.yml start region=dev                OLD: ["sandbox"] + start (us)  <- the old bug
needs_sandbox:dev:4:taPwa       NEW: ["sandbox :test_tube:"] + sandbox.yml start region=dev                OLD: nothing
stop_sandbox [test_tube,sandbox] NEW: DELETE test_tube; DELETE sandbox; stop all (dev included)           OLD: DELETE sandbox; stop all
needs_sandbox / :4 / :ap, needs_ci                     identical before and after

bash -n entrypoint.sh passes.

Payloads (stub curl): prod requests are unchanged, {"ref":"master","inputs":{"pr":"N"}}. Dev requests add "ef_region":"dev-us". GitHub rejects an input the workflow on master doesn't declare (422), so merge after vscode#125595.

Merged with master (2026-11-20): resolved conflicts with #39 (start on needs_sandbox also when the label is on) and #41 (stop_sandbox stops every region). needs_sandbox:dev now goes through master's wanted_label/region chain, so it gets #39's behaviour too. Re-checked the routing with the file's own regex and chain: needs_sandbox:dev, e2e_needs_sandbox:dev and needs_sandbox:dev:4 → sandbox :test_tube: / region=dev; needs_sandbox, :eu, :ap unchanged. On master, needs_sandbox:dev → sandbox / us, as seen on vscode#125932.

🤖 Generated with Claude Code

asheth-eightfold and others added 3 commits November 18, 2026 11:35
… dev account (ENG-226579)

- needs_ci_dev, needs_ci_dev:lite: add the label and start ci_k8s_full_dev.yml /
  ci_k8s_lite_dev.yml (vscode), which run the suite pods in the dev region's account
  and remove the label when they finish.
- needs_sandbox:dev: `sandbox :test_tube:` and sandbox.yml region=dev. `dev` moves
  from the hours group to the region group: until now `needs_sandbox:dev` matched the
  hours group and started a us-west-2 sandbox.
- stop_sandbox stops the dev sandbox too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… dev

The dev runs are now a job of the existing CI k8s workflows (vscode#125595), not
files of their own. ci_k8s_request takes an optional account; a prod request's
payload is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The vscode workflows (vscode#125595) take the EF region the run happens in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@asheth-eightfold asheth-eightfold changed the title needs_ci_dev and needs_sandbox:dev: CI k8s in the dev account (ENG-226579) needs_ci_dev and needs_sandbox:dev: CI k8s in the dev region, dev-us (ENG-226579) Nov 19, 2026
@asheth-eightfold
asheth-eightfold marked this pull request as ready for review November 20, 2026 12:00
Conflicts in entrypoint.sh against #39 (start on needs_sandbox also when the label is on) and
#41 (stop_sandbox stops every region). Took master's structure and added dev to it:
- needs_sandbox:dev picks `sandbox 🧪` / region dev in master's wanted_label chain, so
  it gets #39's behaviour too;
- stop_sandbox removes `sandbox 🧪`; master's `stop all` already stops dev.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@asheth-eightfold
asheth-eightfold merged commit a03f055 into master Nov 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant