Repository navigation
Ask the CI k8s sandbox to start on needs_sandbox also when the PR already has that region's label (ENG-226364) - #39
Merged
Conversation
…eady has that region's label (ENG-226364) A needs_sandbox on a PR that already carries the requested region's sandbox label now dispatches sandbox.yml start as well (the label is left as it is, so the fleet sees no change). vscode's launcher decides from what is actually running (EightfoldAI/vscode#125494): a sandbox still running is left as it is and, when live, the developer is told so ("comment stop_sandbox first"); a label left on with nothing behind it -- a start that failed before its pod reported, a pod killed outright -- gets a new sandbox, instead of blocking every later needs_sandbox as it does today. Another region's label still blocks a new one, and nothing changes while SANDBOX_K8S_TRIGGER is off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
asheth-eightfold
added a commit
that referenced
this pull request
Nov 20, 2026
Conflicts in entrypoint.sh against #39 (start on needs_sandbox also when the label is on) and #41 (stop_sandbox stops every region). Took master's structure and added dev to it: - needs_sandbox:dev picks `sandbox 🧪` / region dev in master's wanted_label chain, so it gets #39's behaviour too; - stop_sandbox removes `sandbox 🧪`; master's `stop all` already stops dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
needs_sandboxon a PR that already carries the requested region's sandbox label now also dispatchessandbox.ymlstart. The label is left as it is, so the fleet sees no change.Why: today a
sandboxlabel left on with no sandbox behind it blocks every laterneeds_sandboxsilently. That covers a start that failed before its pod reported, and a pod killed outright. Thealready_needs_sandboxcheck neither adds a label nor dispatches. The developer has no way back except commentingstop_sandboxfirst, which nothing tells them to do.What vscode does with the dispatch (EightfoldAI/vscode#125494,
launch_sandbox.start()):abc1234, live at<url>until 12:30 UTC. To start a new one, commentstop_sandboxfirst, thenneeds_sandboxagain."This is the same rule
shipit_k8s_requestalready follows: commenting again is how you ask again.needs_sandboxsandbox, dispatch startneeds_sandbox(also:2:taPwa,e2e_)sandboxneeds_sandbox:apsandbox :australia:needs_sandboxsandbox :australia:(another region)needs_sandbox:eusandbox :eu:, dispatch start euSANDBOX_K8S_TRIGGERfalsestop_sandboxsandboxTesting
I ran
entrypoint.shon this branch and onmasteragainst event payloads for the 10 cases above, with a stubcurlthat records every call.sandbox.ymlstartdispatch in the four "this region's label is already on" cases.SANDBOX_K8S_TRIGGERoff, the two versions are identical in every case.bash -nis clean.The vscode side is tested in EightfoldAI/vscode#125494, on the CI k8s cluster as well as with unit tests.
Merge order
Merge EightfoldAI/vscode#125494 first, then this. vscode uses
EightfoldAI/comment_actions@master, so this takes effect on every PR as soon as it merges. Merged first, it would send repeatedneeds_sandboxcomments to today's launcher, which replaces a running sandbox.JIRA: ENG-226364
🤖 Generated with Claude Code