Repository navigation
Store date-times with finer precision in milliseconds instead of failing - #70
Merged
Merged
Conversation
# Conflicts: # CHANGELOG.md # tests/test_convert_duckdb.py
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical active finding remains in the timestamp conversion: integer division is performed as floating-point, causing incorrect handling of negative sub-millisecond values and potentially failing or truncating the cast.
1 open issue
2 resolved since last review
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing GeoParquet floors date-times to milliseconds, as the specification defines, instead of failing on finer precision. Applies to
GeoParquet.writeand the DuckDB converter.