Repository navigation
Fix the keyword rules for merging schemas - #69
Merged
Merged
Conversation
The match cases were sequence patterns and never matched. vec merge now merges custom schemas so that every dataset's features stay valid: enums are joined, bounds widened and only what every dataset requires stays required.
m-mohr
force-pushed
the
fix-schema-merge-keywords
branch
from
November 7, 2026 00:32
0fb10f4 to
ae94645
Compare
This reverts commit 9242006: const, multipleOf, not, anyOf etc. are JSON Schema keywords that SDL doesn't allow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The match cases were sequence patterns and never matched. vec merge now merges custom schemas so that every dataset's features stay valid: enums are joined, bounds widened and only what every dataset requires stays required.