Repository navigation
cmp: return from parse_params on --help instead of exiting - #432
Open
qodelicious wants to merge 1 commit into
Open
qodelicious wants to merge 1 commit into
qodelicious wants to merge 1 commit into
Conversation
Return a help flag to the caller and print usage in main. Remove the fuzzing exclusion and cover help parsing and command output. Assisted-by: AI coding assistant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmp::parse_paramscalledprocess::exit(0)when it saw--help, which killed the whole process for any caller, including the fuzz target (which had to filter--helpout).It now sets a
helpflag onParamsand returns.cmp::mainprints the usage and exits 0 as before, socmp --helpbehaves the same. The--helpfilter infuzz_cmp_argsis removed, and there are unit and integration tests for the help path.Closes #220
Assisted-by: AI coding assistant