Skip to content

cksum: add xxh3 algorithm - #16739

Open
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:cksum-xxh3
Open

sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:cksum-xxh3

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

based on the twox-hash implementation

based on the twox-hash implementation
Copilot AI balanced review requested due to automatic review settings November 20, 2026 18:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@codspeed

codspeed Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will regress 4 benchmarks

3 warnings, 1 note

⚠️ 123 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 12 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 9 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 8 improved benchmarks
❌ 4 regressed benchmarks
✅ 401 untouched benchmarks
🆕 2 new benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation mv_force_overwrite 127.6 ms 153.1 ms -16.64%
❌ CPU Simulation true_consecutive_calls 294.7 ns 350.2 ns -15.86%
❌ CPU Simulation factor_a_prime_to_the_seventh 480.1 µs 502 µs -4.36%
❌ CPU Simulation dd_copy_with_skip 4.8 ms 4.9 ms -3.04%
⚡ Memory socket_addrs_direct[100000] 68 KB 8.6 KB ×7.9
⚡ Memory hostname_ip_lookup[100000] 66.4 KB 9.1 KB ×7.3
⚡ CPU Simulation false_consecutive_calls 350.2 ns 294.7 ns +18.85%
⚡ CPU Simulation split_number_chunks_round_robin 32.8 ms 28.9 ms +13.4%
⚡ CPU Simulation cksum_crc 34.2 ms 32.6 ms +5.03%
⚡ CPU Simulation cksum_raw_output 34.2 ms 32.8 ms +4.14%
⚡ CPU Simulation cksum_default 33.9 ms 32.8 ms +3.29%
⚡ CPU Simulation cksum_multiple_files 51.1 ms 49.5 ms +3.27%
🆕 Memory cksum_xxh3 N/A 42.2 KB N/A
🆕 CPU Simulation cksum_xxh3 N/A 179.8 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:cksum-xxh3 (08c7ed7) with main (9311390)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (276ffe9) during the generation of this report, so 9311390 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants