Skip to content

utmpx: load the opt-in logind backend at runtime - #16478

Open
mattsu2020 wants to merge 2 commits into
uutils:mainfrom
mattsu2020:utmpx/runtime-logind-loader
Open

mattsu2020 wants to merge 2 commits into
uutils:mainfrom
mattsu2020:utmpx/runtime-logind-loader

Conversation

@mattsu2020

Copy link
Copy Markdown
Contributor

Load the existing opt-in logind backend through libsystemd.so.0 at runtime instead of linking it at build time. Keep the current feature names, record API and source-selection behavior, and test missing libraries and symbols.

Split from #11579; related to #8376. The default-utmp fallback remains in #11579.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/tail/follow-name is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!

@codspeed

codspeed Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will regress 2 benchmarks

3 warnings, 1 note

⚠️ 116 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 6 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 6 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 5 improved benchmarks
❌ 2 regressed benchmarks
✅ 406 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation df_deep_directory 881.4 µs 932.9 µs -5.53%
❌ Memory tr_ascii_range_lower_to_upper 131.8 KB 138.4 KB -4.82%
⚡ CPU Simulation file_custom_format 15.8 ms 11.5 ms +38.18%
⚡ CPU Simulation file_iso_dates 17.7 ms 13.4 ms +32.33%
⚡ CPU Simulation file_localized_names 27.1 ms 22.7 ms +19.29%
⚡ CPU Simulation split_number_chunks_round_robin 32.8 ms 28.9 ms +13.39%
⚡ CPU Simulation file_tz_abbreviations 18.1 ms 16.8 ms +7.72%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mattsu2020:utmpx/runtime-logind-loader (b16ae58) with main (e1b90fa)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (a663b44) during the generation of this report, so e1b90fa was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sylvestre
sylvestre force-pushed the utmpx/runtime-logind-loader branch 2 times, most recently from 35ceb50 to 41d9827 Compare November 18, 2026 04:52
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.50 MB (+116 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@sylvestre
sylvestre force-pushed the utmpx/runtime-logind-loader branch from 41d9827 to b16ae58 Compare November 19, 2026 11:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants