Skip to content

build: use shared bsd cfg alias - #15634

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:refactor/cfg_aliases/bsd
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:refactor/cfg_aliases/bsd

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Use a shared cfg alias for BSD targets to reduce duplication and keep platform-specific conditional compilation consistent across the codebase.

Closes #15423.
Follow-up to #10443.

@oech3

This comment was marked as resolved.

@codspeed

codspeed Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 15.04%

3 warnings, 1 note

⚠️ 121 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 8 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 8 improved benchmarks
✅ 405 untouched benchmarks
⏩ 70 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ CPU Simulation file_custom_format 15.8 ms 11.5 ms +38.18%
⚡ CPU Simulation file_iso_dates 17.7 ms 13.4 ms +32.32%
⚡ CPU Simulation file_localized_names 27.1 ms 22.7 ms +19.31%
⚡ CPU Simulation true_consecutive_calls 350.2 ns 294.7 ns +18.85%
⚡ CPU Simulation file_tz_abbreviations 18.1 ms 16.8 ms +7.74%
⚡ CPU Simulation dd_copy_8k_blocks 1.9 ms 1.9 ms +3.2%
⚡ CPU Simulation dd_copy_with_seek 5 ms 4.9 ms +3.19%
⚡ CPU Simulation dd_copy_with_skip 4.9 ms 4.8 ms +3.15%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:refactor/cfg_aliases/bsd (ef2e237) with main (e1b90fa)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (a663b44) during the generation of this report, so e1b90fa was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze marked this pull request as ready for review October 22, 2026 20:07
@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch 2 times, most recently from 9d4a68e to 8b0ebf8 Compare October 22, 2026 20:26
@xtqqczze
xtqqczze requested a review from sylvestre October 22, 2026 23:07
@xtqqczze
xtqqczze requested a review from cakebaker October 23, 2026 15:05
@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from 8b0ebf8 to 4024f85 Compare October 25, 2026 12:15
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@sylvestre ready

@oech3

oech3 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This is maintainer's decision, but it would be nice if #15299 was merged at 1st which was reciently rebased by maintainer.

@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch 2 times, most recently from 1c76ded to f989cb7 Compare October 31, 2026 10:56
@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from f989cb7 to f94f62a Compare November 2, 2026 21:15
@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch from f94f62a to da7d7f1 Compare November 3, 2026 11:51
@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from da7d7f1 to 18ed618 Compare November 6, 2026 10:25
@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch from 18ed618 to 2f8cedd Compare November 13, 2026 22:39
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/tail/follow-name is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!

@oech3

oech3 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Is this OK to merge?

@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from 2f8cedd to 8b4f06b Compare November 16, 2026 11:31
@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch 2 times, most recently from d0db05b to 5d2aceb Compare November 17, 2026 15:26
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.49 MB (+108 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from 5d2aceb to ef2e237 Compare November 19, 2026 10:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_stty.rs: Support bsd cfg_aliases

2 participants