Skip to content

build(who): gate by target support - #15421

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:deps/gate-who
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:deps/gate-who

Conversation

@xtqqczze

Copy link
Copy Markdown
Collaborator

Closes #15420.

@xtqqczze
xtqqczze force-pushed the deps/gate-who branch 2 times, most recently from 4619b96 to 2ba0fec Compare October 16, 2026 17:24
@xtqqczze xtqqczze self-assigned this Oct 25, 2026
@xtqqczze

This comment was marked as outdated.

@codspeed

codspeed Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 3.25%

3 warnings, 1 note

⚠️ 119 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 3 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 5 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 407 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation true_consecutive_calls 294.7 ns 350.2 ns -15.86%
❌ CPU Simulation cksum_crc 33.1 ms 34.2 ms -3.25%
❌ CPU Simulation cksum_raw_output 33.3 ms 34.5 ms -3.22%
❌ CPU Simulation cksum_multiple_files 49.5 ms 51.1 ms -3.17%
⚡ CPU Simulation df_deep_directory 930.1 µs 892 µs +4.27%
⚡ CPU Simulation dd_copy_with_skip 4.9 ms 4.8 ms +3.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:deps/gate-who (efc6438) with main (2775292)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@xtqqczze
xtqqczze force-pushed the deps/gate-who branch 2 times, most recently from 16125fa to 3db10c9 Compare November 3, 2026 12:07
@xtqqczze
xtqqczze marked this pull request as ready for review November 4, 2026 10:07
Comment thread src/uu/who/src/who.rs Resolved
Comment thread src/uu/who/src/platform/mod.rs Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

who: gate by target support

2 participants