Skip to content

build: change clippy lint from expect to allow for match_same_arms - #15306

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:build/uucore-build-match-same-arms
Oct 14, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:build/uucore-build-match-same-arms

Conversation

@xtqqczze

Copy link
Copy Markdown
Collaborator

Addresses #14965 (comment).

@codspeed

codspeed Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 13.53%

⚠️ 125 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 2 regressed benchmarks
✅ 396 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation factor_three_39_bit_primes 321.7 ms 704.9 ms -54.36%
❌ Simulation factor_thirteen_39_bit_primes 9.2 s 9.8 s -5.73%
⚡ ⚠️ Simulation du_all_wide_tree[(5000, 500)] 35.7 ms 34.2 ms +4.45%
⚡ Simulation factor_five_38_bit_primes 1.5 s 1.5 s +4.34%
⚡ Memory du_all_wide_tree[(5000, 500)] 1,041.8 KB 1,010.6 KB +3.08%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:build/uucore-build-match-same-arms (bf3ddb4) with main (1747ba1)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@oech3

oech3 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

I think we should disable all clippy for gegerated *.rs files. I don't know how to do that.

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

We could emit #![allow(clippy::all)] in generated code.

@cakebaker
cakebaker merged commit 853c36d into uutils:main Oct 14, 2026
187 of 190 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants