Repository navigation
Fix hash expectations for minitest 6.1 - #96
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 9 9
Lines 363 363
Branches 46 46
=======================================
Hits 359 359
Misses 1 1
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minitest 6.1.0 treats bare hashes passed to
must_equalas keyword arguments, causing 13 existing behavior tests to fail before comparing the expected value. Give those expected hashes explicit braces so the same assertions work with minitest 5 and 6. Library code and dependency requirements are unchanged.Ruby 3.1 also needs Ubuntu 24.04: the first CI run failed during Ruby setup after
ubuntu-latestmoved to 26.04. Use 24.04 for the supported Ruby matrix on x64 and arm64. This runner configuration is validated by CI rather than a source-text test.The expanded matrix also exposed an existing order-dependent warning assertion: MultiJson deprecations can appear alongside the SDK's rate-limit warning when this test runs first. Require the exact warning line exactly once among stderr lines. Seed
13766reproduces the failure before this assertion change and passes afterward.Validation:
13766.13766; only the optional live upload is skipped locally.13766.bundle exec standardrbpasses on Ruby 3.1 and 4.0 (x64), and Ruby 4.0 (arm64).git diff --checkandactionlintpass.Council review: six rounds. Rounds 1–3 were clean; round 4 requested retaining duplicate-warning detection, so the warning assertion now counts exactly one matching line. Rounds 5 and 6 reviewed the full final diff and were consecutive clean rounds. The existing public API test demonstrates the warning and retry behavior; no test of the assertion itself was added.
Publishing is manual; merging does not publish to RubyGems.
Closes #95
🤖 Claimed by kvz on
framework1/ruby-sdksince 2026-11-12 · resume:codex resume 01a1cf95-44cc-7a03-a63d-fb007674476e