Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #275.
What
CSS-only "stretched link" in
ui/src/styles.css:tr.clickablelands on the row's real primary-cell<Link>, so the JEF-431/JEF-443 model is unchanged: one tab stop per row, native cmd/middle-click and open-in-new-tab, no whole-rowonClickorrole="link", nothing new for jsx-a11y to flag.Applies to Traces, Metrics, Services and Alerts (the tables that use
rowlink). Logs rows aretr.clickabletoo but have no row link — untouched here.Trade-off: text inside those rows can no longer be drag-selected, since the overlay takes the pointer. The lists don't show ids or other copy-worthy values (the detail pages do), so it seemed worth it — easy to scope differently if you'd rather.
Tests
npm run lint,npm test,npm run build. Verified by hand: clicking the Duration cell of a trace row opens the trace; Metrics expander still expands series.🤖 Generated with Claude Code