Skip to content

fix(ui): clicking anywhere on a clickable row follows its link - #276

Open
vmax wants to merge 1 commit into
thejefflarson:mainfrom
vmax:fix/whole-row-click
Open

vmax wants to merge 1 commit into
thejefflarson:mainfrom
vmax:fix/whole-row-click

Conversation

@vmax

@vmax vmax commented Nov 15, 2026

Copy link
Copy Markdown

Closes #275.

What

CSS-only "stretched link" in ui/src/styles.css:

tr.clickable { position: relative; }
tr.clickable .rowlink::after { content: ""; position: absolute; inset: 0; }
tr.clickable button,
tr.clickable a:not(.rowlink) { position: relative; z-index: 1; }
tr.clickable:hover .rowlink { text-decoration: underline; }
  • A click anywhere on a tr.clickable lands on the row's real primary-cell <Link>, so the JEF-431/JEF-443 model is unchanged: one tab stop per row, native cmd/middle-click and open-in-new-tab, no whole-row onClick or role="link", nothing new for jsx-a11y to flag.
  • Other controls inside a row stay on top and keep working — checked the series expander (▸) on Metrics still toggles instead of navigating.
  • The identity link underlines on row hover, so the row's hover state also says where the click goes (weight + underline, never color — ADR 0009 / WCAG 1.4.1).

Applies to Traces, Metrics, Services and Alerts (the tables that use rowlink). Logs rows are tr.clickable too but have no row link — untouched here.

Trade-off: text inside those rows can no longer be drag-selected, since the overlay takes the pointer. The lists don't show ids or other copy-worthy values (the detail pages do), so it seemed worth it — easy to scope differently if you'd rather.

Tests

npm run lint, npm test, npm run build. Verified by hand: clicking the Duration cell of a trace row opens the trace; Metrics expander still expands series.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List rows look clickable everywhere but only the first cell navigates

1 participant