Repository navigation
audio: count frames the host stream skips in the real-clock tone tests - #795
Merged
techomancer merged 4 commits intoNov 20, 2026
Merged
techomancer merged 4 commits into
techomancer merged 4 commits into
Conversation
On a loaded Windows runner the file backend's thread can stall long enough for the queue to pass its ceiling; the stream then skips ahead (overruns) or the ring refuses frames (dropped). Those frames reached the host and were let go on purpose, so the check that every moved frame reached the file now adds them back before allowing for what is still queued at the stop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…test The O2 test makes the same check as HAL2's: every pair played before the mute must reach the file, give or take what was still queued. A file thread stalled on a busy host makes the stream skip ahead or refuse pairs on purpose, so those are now added back too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…indows-audio-test-e8b723 # Conflicts: # src/dev/mace_audio.rs
The Octane test makes the same lower-bound check as HAL2's and the O2's. Frames the host stream skips or refuses after a stalled file thread are added back, converted from the card's 44.1 kHz to the file's 48 kHz. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Windows failure in https://github.com/techomancer/iris/actions/runs/44681210910/job/136104933706:
The guest clock ran on time (38424 frames in 0.8 s), but about 286 ms of them never reached the WAV. When the file backend's thread is held up on a busy runner, the queue passes
max_latencyand the stream skips ahead to its target (overruns), or the ring is full andwriterefuses frames (dropped). That is the intended behaviour. The test only allowed 200 ms for what was still queued at the stop.The test now reads the stream's stats before stopping and adds
overruns + droppedto the frames heard, then applies the same 200 ms allowance. The frequency and level checks on what was heard are unchanged.The O2's (
mace_audio) and the Octane's (rad1) real-clock tone tests make the same check and get the same accounting; RAD1's skipped frames are converted from the card's 44.1 kHz to the file's 48 kHz. Upstream's 83c8ddd loosened the upper bound of the MACE and RAD1 checks; this PR keeps that and fixes the lower one.Tested:
cargo test --release --lib hal2::host_tests(3/3)cargo test --release --lib mace_audio(11/11) andcargo test --release --lib rad1::(70/70) pass on macOS. The first commit passed this PR's CI, Windows included.🤖 Generated with Claude Code