Repository navigation
iris-gui: o2 support in the summary, disk check and new machine dialog - #794
Merged
techomancer merged 3 commits intoNov 20, 2026
Merged
Conversation
The stopped-machine summary now lists the NVMe card and Fibre Channel disks, names SCSI targets on a second bus as controller:id, leaves out the IP35 bricks' unused [scsi] map and shows an unplugged or stream Ethernet. The missing-disk prompt names targets the same way. Both are worked out in the new summary module from the config alone. The rest of issue 304 was already fixed upstream: the O2's own o2.prom, o2.disks and similar keys are folded into the shared keys on load, so the summary and the disk check read the O2's settings, and the Advanced tab edits [o2]. Tests cover a config in that old spelling. Refs techomancer#304 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nly on the Indigo2 A drive with no image reads "no image chosen" (a CD-ROM "tray empty") in the summary instead of ending in a comma. The New machine dialog names the machine after the chosen model until a name is typed, and it and the settings editor offer the motherboard EEPROM file only on the Indigo2: the Indy keeps its PROM environment in the NVRAM. Refs techomancer#304 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The summary shows the machine folder and gives paths inside it relative to it, cut to the panel's width with the full path in the tooltip; long absolute paths ran off the window. Coloured buttons get white text, which the light theme's dark grey made hard to read on green, red and blue. The status footer shows "No network" with no light on a machine with networking off and names a running stream network; a build without PCAP no longer records off or stream as NAT. Refs techomancer#304 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304.
Most of #304 was already fixed: the O2's own
o2.prom,o2.disksand similar keys are now folded into the shared keys when a config loads. As a result, the summary and the Start disk check already read the O2's settings. This PR fixes what was still Indy-shaped in the GUI.Summary and Start check
controller:id(for example the O2's external1:3), not by its[scsi.N]key.[scsi]map is left out.New machine dialog and settings
Buttons
The summary and disk-check logic now lives in a new
iris-gui/src/summary.rs, which works from the config alone so it can be tested without a window. Docs:iris-gui-README.md,CHANGELOG.md, and a clanker note.Testing
cargo test -p iris-guipasses. New tests cover an O2 by placement, the deprecated[o2] disksspelling, empty and scratch targets, the IP35, the Indy, the network modes, relative paths and default names.🤖 Generated with Claude Code