Repository navigation
Keep constrained drawings clear of captions - #713
EricHuang0302 wants to merge 10 commits into
Conversation
752980d to
d992bfb
Compare
d992bfb to
fcb70ed
Compare
|
CI failed only on a 4s token-request timeout in the Python pending-judge startup test. |
|
@EricHuang0302 Yes, wherever the card sits in its own row. At 1024px and above, Move the Then assert in the |
Place a cramped caption card below the expanded drawing and reserve its measured height at stacked widths. Refresh floating placement after mode changes and preserve ending/report inertness without moving the stage. Extend label, caption and overlay checks on the real page at stacked widths while keeping the desktop reservation where it fits. Change-Id: Ibe7a5a4b784f54b2a6669939cfd9919811dfeabf
Use the configured sidebar track and editor minimum to decide when the workspace must stack. Transfer focus before hiding the divider and scroll only on explicit expansion, preserving reading position on resize. Keep captions below the editor in the forced stack, restore the original columns on shrink, and cover the enlarged-font and resize cases. Close sysprog21#704 Change-Id: I1dd7c99308814ea54153cb628450d64613747227
Reserve the caption card's 40dvh cap for the editor instead of its live height, so captions that stream in no longer move the text controls while a pointer is pressed on them. Apply the height whenever the card sits below the editor, not only under 1024px. Give the captions a floor of the heading plus one line, so a short viewport scrolls the card instead of squeezing the text away. Close sysprog21#704 Change-Id: Ifb8a5fe63f17ce2defaae652d491f6cd4a8fdda1
|
@EricHuang0302 Asking again for my 2026-11-18 comment (#713 (comment)), which this head (
Push both to this branch together with the rebase. |
fcb70ed to
831f200
Compare
No merge conflicts at the current head.
|
The height rule now follows The gate note for |
Remove the rem-based panel floor and assert full canvas and caption visibility at 32px. Keep drawing tools on a scrollable row and captions first so short windows retain usable drawing space. Reuse the expanded drawing state and let placement alone manage the scrollable card class. Scroll relocated divider focus into view without moving readers on ordinary resize. Change-Id: I7c9c26c4937d772dfd470746b4c257391ba5f98d
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
View guided diff | Re-trigger cubic
|
Some review comments on this pull request are not settled yet. Please refine the change per the review comments listed below, reply on each thread with what you changed or why you did not, and mark each thread resolved yourself once it is settled (Resolve conversation, at the bottom of the thread). The pull request stays blocked while review threads are open. Not addressed at the current head:
Checked at c3aeed5. |
Use the same resize fixture to check reading position and focus. Change-Id: I2f6951d378e01ae2a9a02052be233d6115e1de5b
Place captions before the turn row so Tab follows the visual order. Scale constrained cards with enlarged fonts and reserve a caption line below the Unclear control. Keep toolbar focus rings inside the scrollport. Change-Id: I4f89d10d73df843841ee8069efcd0f0adcc1d626
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/browser/interview-layout.test.js">
<violation number="1" location="tests/browser/interview-layout.test.js:1173">
P3: For width 900, this scrolls the editor into view before measuring it, so the editor and canvas bounds checks no longer prove that expansion brought them into view. Measure before the `scrollIntoView` call, as the 1024px cases do, and keep the scroll only for later interactions.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Preserve the floating card and its transcript scroll behavior. Change-Id: I2a55a4315e22c0457b70c5de533e6f60ee067a2e
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Restore the caption scroll offset after moving its controls. Change-Id: Id7031d84488b2efcfe7ba93f72fc4216342ac67b
Reserve canvas height and verify docking after overlays close. Change-Id: I0ce1ee2fe5e564355ab5c02527b5144a0a015316
Center the canvas after each draft interaction before clicking again. Change-Id: I74f60e94dac01675c06374b5531b1955aaeeaf9f
|
The 900×320 failure comes from click coordinates above the viewport after earlier draft interactions. Centering the canvas before each click fixes it locally, with all 205 related browser tests passing. The test-only fix is ready, but the pre-push Rust gate repeatedly fails in unchanged await canvas.evaluate((node) => node.scrollIntoView({ block: "center" }));
const rect = await canvas.boundingBox();
assert.ok(rect.y >= 0 && rect.y + rect.height <= height); |
Expanded Example drawings can put label controls beneath Jim's caption card. When the card cannot fit beside the drawing, place it below the editor and reserve its
40dvhheight cap. Stack the workspace when the sidebar's current width and the editor's minimum width cannot fit side by side.The constrained editor follows the viewport budget without a rem-based height floor. Drawing tools stay on a horizontally scrollable row, and captions come first in the capped, scrollable card. Explicit expansion and relocated divider focus bring the editor into view; ordinary resizing preserves the reading position. Shrinking and ending/report transitions restore placement and inertness.
The docked card puts captions before the turn controls in the document, so Tab follows the displayed order. The floating card keeps its original order. The two 1024×800 cases cover normal expansion and divider focus separately, with no test scroll before checking the editor and canvas.
On
5a96bbc4, 205 related browser tests passed with no skips. Linux Rust gate passed with three test threads, one Tokio worker and a one-second DNS retry setting, with desktop and cargo-deny skipped. The full macOS run reported LiveKit fixture failures. The 900×700 transcript case also passes on Linux. Drawing toggles preserve the caption scroll offset, and 900×320 at 32px retains a usable canvas with page scrolling. The browser tests use the real page with a test fixture and do not join a live interview.Earlier 900px layout comparison, before the caption-sizing refinement
Earlier enlarged-font layout comparison
Close #704