Repository navigation
Copy the visible test results - #698
seallllllllll wants to merge 1 commit into
Conversation
EricHuang0302
left a comment
There was a problem hiding this comment.
Prepared with Codex; checkout, tests and mutation checks were performed by the agent at 29613ec.
node --test tests/browser/results-copy.test.js tests/browser/compiler-diagnostic-navigation.test.js tests/browser/candidate-cases.test.js43 passed, 0 failed, 0 skipped
Two additional local probes pass on this revision. Each catches its corresponding mutation while the existing tests remain green. The inline comments suggest coverage improvements; no current behavior failure was reproduced.
|
Some review comments on this pull request are not settled yet. Please refine the change per the review comments listed below, reply on each thread with what you changed or why you did not, and mark each thread resolved yourself once it is settled (Resolve conversation, at the bottom of the thread). The pull request stays blocked while review threads are open. Not addressed at the current head:
Checked at 29613ec. |
Let candidates reuse compiler diagnostics and visible test results without selecting panel text manually. Copy only result content so runner and navigation notices do not pollute diagnostic text. Reuse the existing copy feedback and keep stale writes from announcing a newer run. Close sysprog21#598 Change-Id: I710ec6db2f909943cba3635e79694ea63037de12
29613ec to
68bfbd2
Compare
Candidates can copy the currently displayed test results and compiler diagnostics as plain text. The action follows the existing filter, excludes runner and navigation notices, and is unavailable before results exist, while tests run, or after invalidation. Both copy actions share pending-write protection, accessible feedback and clipboard failure handling.
Validation: make indent, make indent-check and Clippy pass. The Linux Rust lane passes with Rust 1.100.0 (2,991 passed, 29 ignored), and the portable lane passes with its reported skips. The focused browser suites pass, and isolated mutations verify pending-write and feedback-timer coverage. Full browser validation remains non-green: Linux reports a Jim scrolling timeout also reproduced on upstream/main; macOS reports five failures, one cancellation and one skip. The two restore-starter failures pass when run alone. Windows clipboard behavior and credentialed integrations have not been run.
Close #598