Repository navigation
Conversation
Update lightning to 0.2.8, lightning-types to 0.3.5 and lightning-invoice to 0.34.2 on top of v0.8.0-rc11.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Moves lightning to 0.2.8, lightning-types to 0.3.5 and lightning-invoice to 0.34.2 in the lock on top of v0.8.0-rc11, and bumps the version to 0.8.0-rc11.1 across the three manifests. Reviewed 89f3cee, full tier (lock file change).
What I checked, and 3 candidates I ruled out
Base: release/0.8.0-rc11 is 22e0acc, the commit v0.8.0-rc11 points at, so the diff is the whole delta for the patch line.
Lock integrity: the three new checksums match the crates.io index entries for lightning 0.2.8, lightning-types 0.3.5 and lightning-invoice 0.34.2, none yanked. Every non-optional requirement of the new lightning (lightning-macros ^0.2.1, dnssec-prover ^0.6, hashbrown ^0.13, possiblyrandom ^0.2, lightning-types ^0.3.5, bech32 ^0.11) resolves to an entry already in the lock, so no new crate enters the graph.
Scope: boltz-client 0.4.1 is the only lock entry that depends on lightning; the crate's own lightning-invoice = "0.32.0" in Cargo.toml is a separate entry and untouched.
Version sync: Cargo.toml, Package.swift (tag) and bindings/android/gradle.properties all read 0.8.0-rc11.1; no other tracked file carries the old version outside the changelog and lock.
CI at review time: manifest and SwiftPM checks green; Android Bindgen, iOS Bindgen and usdt-tests still pending.
Build: build skipped: the PR-run gate could not read the author's permission on this repo and fails closed, so the review is static. The iOS checksum in Package.swift was not recomputed here; it can only be checked against the release asset once it is uploaded, which is step 2 of the release plan.
Ruled out
- Pre-release ordering:
0.8.0-rc11.1sorts after0.8.0-rc11and before0.8.0-rc12under SemVer (identifiersrc11then1), so a consumer pinning the rc11 line does not jump to master's releases. - Android publish from the tag:
gradle-publish.ymlchecks outrelease.tag_nameand passes the version from it, so it builds this branch's code, not the default branch. - Binding drift: no Rust source or UniFFI export changed, so there is nothing for the generated bindings to pick up.
Merge confidence: 4/5, the lock change was not built or tested here and three CI jobs were still pending.
coreyphillips
left a comment
There was a problem hiding this comment.
Two independent reviews, nothing blocking a merge.
|
Closing unmerged: in bitkit-core the LDK 0.2.8 crates reach only |
Refs: #207
Prepares
0.8.0-rc11.1for the Bitkit 3.1.1 patch line. v3.1.0 ships0.8.0-rc11; this branch adds only the LDK 0.2.8 crates on top of it, so 3.1.1 gets the LDK update without the rc12–rc14 changes. Master stays on0.8.0-rc15for 3.2.0.Description
lightning0.2.3 → 0.2.8,lightning-types0.3.2 → 0.3.5 andlightning-invoice0.34.1 → 0.34.2 inCargo.lock, the same lock change as chore: prepare 0.8.0-rc15 #207.boltz-clientis the only crate that depends on them.0.8.0-rc11.1inCargo.toml,Cargo.lock,Package.swiftandbindings/android/gradle.properties, plus the iOS checksum inPackage.swift.No API change: the regenerated Swift bindings are byte-identical to
v0.8.0-rc11.This PR targets
release/0.8.0-rc11, cut at thev0.8.0-rc11tag (22e0acc).The iOS archive was built with
./build_ios.shon Rust 1.91.1 and Xcode 27.0. It is 86,783,449 bytes, SHA-2568414875259de52a50d8f7e3b8f638cbd31d1938d650bb1e257596a29265706f2, matchingPackage.swift. Android coordinates arecom.synonym:bitkit-core-android:0.8.0-rc11.1.Release steps after approval
v0.8.0-rc11.1on the approved head and publish it as a prerelease with the preservedBitkitCore.xcframework.zip, sov0.8.0-rc15stays the latest release. Publishing runsgradle-publish.yml, which builds and publishes the Android package.Package.swiftand that the Android package resolves.QA Notes
cargo metadata --lockedresolves the lock as committed../build_ios.sh: passed. The regenerated Swift interface files are identical tov0.8.0-rc11's.swift package compute-checksumon the archive matchesPackage.swift.cargo test modules::boltz(32 passed) andmodules::scanner(19 passed).