Repository navigation
Add dependency-aware generated packaging checks - #39
Conversation
Stage enabled directory-local install rules in an isolated test prefix, including dependencies excluded from parent installs. Compile, link, and run a consumer using the staged package while preserving external dependency prefixes and normal installation behavior. Cover excluded and transitive dependencies, static/shared libraries, multi-config Debug, disabled installs, external prefix lists, and stale-installation false positives. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Talos pre-flight review
Verdict: Changes need attention. Reviewed head: 3628a32d864520e6ed208c056fe51607b37ec4b1 against main. Three findings were accepted and posted inline; two candidates were rejected by challenge (one unsupported install contract and one duplicate). No overflow.
Coverage: all 12 changed files reviewed by five completed personas and the challenge reviewer. The security persona returned an empty result after receiving an incomplete diff, so security review coverage is incomplete. i18n was not applicable; test-quality review is not enabled. Scout was used (complete packet, LOW risk / HIGH evidence); it listed no must-run tests. Local validation and all seven CI jobs passed for this head. Org knowledge was off.
Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Talos pre-flight review
Verdict: Changes need attention. Reviewed head 8f104051d0bf63e374de345cb9adff97f77d9735 against main. Three findings were accepted and posted inline; four persona observations were deduplicated to three candidates, and all three passed challenge. No overflow.
Coverage: 14 changed files, six personas and a challenge reviewer. The full diff and base project instructions were supplied through files; no active OpenSpec change was found. Scout was used (complete packet; MEDIUM risk, HIGH evidence) with conservative whole-file roots for 11 changed files. Local artifact regression and install unit suite passed; all seven PR CI jobs passed. DCAP routing and org knowledge were off; i18n was not applicable and test-quality review was not enabled.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Talos review
Verdict: Needs attention. Reviewed 978311e94186755602fc42f3521939c1aef495fb against main.
Six static personas and challenge reviewed 14 changed files. One candidate was validated and accepted; one finding is posted inline, with no overflow. Scout evidence was used; org knowledge and DCAP routing were off. The complete diff and base rules were supplied to reviewers as local files rather than embedded in the prompts. Local install, setup, documentation, and package-check regressions passed on macOS; Windows validation is pending CI.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
find_package()resolves the package only from the staged prefix, then build and test a downstream consumer.Test plan
cmake -P tests/install/CMakeLists.txt— 32 passed, 1 intentional skip.cmake -P tests/install/test_provider_merge.cmakecmake -P tests/install/test_nested_install.cmake— 11 cases.cmake -P tests/install/test_package_ci.cmake— 8 scenarios.cmake -P tests/setup/test_target_type.cmakecmake -P tests/setup/test_runtime_dlls.cmakecmake -P tests/setup/test_setup_version_resolution.cmakecmake -P tests/docs/test_docs.cmake.Generated with GitHub Copilot CLI