Skip to content

Add dependency-aware generated packaging checks - #39

Merged
sean-parent merged 4 commits into
mainfrom
fix/dependency-aware-packaging
Nov 15, 2026
Merged

sean-parent merged 4 commits into
mainfrom
fix/dependency-aware-packaging

Conversation

@sean-parent

Copy link
Copy Markdown
Member

Summary

  • Generate an isolated installed-consumer check for top-level packages, staging install rules in dependency-first directory order.
  • Verify find_package() resolves the package only from the staged prefix, then build and test a downstream consumer.
  • Replace the generated consumer CI smoke test and add packaging regressions for static/shared, nested, external, and disabled dependencies.

Test plan

  • cmake -P tests/install/CMakeLists.txt — 32 passed, 1 intentional skip.
  • cmake -P tests/install/test_provider_merge.cmake
  • cmake -P tests/install/test_nested_install.cmake — 11 cases.
  • cmake -P tests/install/test_package_ci.cmake — 8 scenarios.
  • cmake -P tests/setup/test_target_type.cmake
  • cmake -P tests/setup/test_runtime_dlls.cmake
  • cmake -P tests/setup/test_setup_version_resolution.cmake
  • AppleClang clangd checks and cmake -P tests/docs/test_docs.cmake.
  • Hosted Windows package coverage and other CI platform/integration jobs pending.

Generated with GitHub Copilot CLI

Stage enabled directory-local install rules in an isolated test prefix, including dependencies excluded from parent installs. Compile, link, and run a consumer using the staged package while preserving external dependency prefixes and normal installation behavior.

Cover excluded and transitive dependencies, static/shared libraries, multi-config Debug, disabled installs, external prefix lists, and stale-installation false positives.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos pre-flight review

Verdict: Changes need attention. Reviewed head: 3628a32d864520e6ed208c056fe51607b37ec4b1 against main. Three findings were accepted and posted inline; two candidates were rejected by challenge (one unsupported install contract and one duplicate). No overflow.

Coverage: all 12 changed files reviewed by five completed personas and the challenge reviewer. The security persona returned an empty result after receiving an incomplete diff, so security review coverage is incomplete. i18n was not applicable; test-quality review is not enabled. Scout was used (complete packet, LOW risk / HIGH evidence); it listed no must-run tests. Local validation and all seven CI jobs passed for this head. Org knowledge was off.

Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).

Comment thread templates/test-package.cmake.in Resolved
Comment thread cmake/cpp-library-ci.cmake Resolved
Comment thread templates/test-package.cmake.in Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos pre-flight review

Verdict: Changes need attention. Reviewed head 8f104051d0bf63e374de345cb9adff97f77d9735 against main. Three findings were accepted and posted inline; four persona observations were deduplicated to three candidates, and all three passed challenge. No overflow.

Coverage: 14 changed files, six personas and a challenge reviewer. The full diff and base project instructions were supplied through files; no active OpenSpec change was found. Scout was used (complete packet; MEDIUM risk, HIGH evidence) with conservative whole-file roots for 11 changed files. Local artifact regression and install unit suite passed; all seven PR CI jobs passed. DCAP routing and org knowledge were off; i18n was not applicable and test-quality review was not enabled.

Comment thread cmake/cpp-library-ci.cmake Resolved
Comment thread templates/test-package.cmake.in Resolved
Comment thread templates/test-package.cmake.in Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos review

Verdict: Needs attention. Reviewed 978311e94186755602fc42f3521939c1aef495fb against main.

Six static personas and challenge reviewed 14 changed files. One candidate was validated and accepted; one finding is posted inline, with no overflow. Scout evidence was used; org knowledge and DCAP routing were off. The complete diff and base rules were supplied to reviewers as local files rather than embedded in the prompts. Local install, setup, documentation, and package-check regressions passed on macOS; Windows validation is pending CI.

Comment thread templates/.github/workflows/ci.yml.in Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sean-parent
sean-parent merged commit cab69a0 into main Nov 15, 2026
7 checks passed
@sean-parent
sean-parent deleted the fix/dependency-aware-packaging branch November 15, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant