Repository navigation
[6.x] Fix half measure static cache serving pages missing from the URL index - #15914
Open
duncanmcclean wants to merge 1 commit into
Open
duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
…ationCacher` Amp-Thread-ID: https://ampcode.com/threads/T-bc731ecc-5236-4cea-8cc5-ad26e5469665 Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where, with the half measure strategy, a page cached while a flush or invalidation was running would stay cached, and no later invalidation could clear it.
This was happening because the
ApplicationCacherforgot responses before their URL index entries, and tracked URLs before their responses were stored. A visitor re-caching a page in between would leave its response stored, but its URL missing from the index, soflush(),invalidateUrl()andinvalidateUrls()could never reach it again.This PR fixes it by making sure a stored response never outlives its index entry:
flush()now reads every domain's keys and forgets the URL indexes inside the URLs lock, then forgets the responses. A page re-cached during the loop lands on a fresh index.invalidateUrl()andinvalidateUrls()now forget the index entries before the responses.cachePage()now tracks the URL once its response has been stored. If an invalidation runs in between, the worst case is an index entry without a response, which just costs a render.Amp thread: https://ampcode.com/threads/T-bc731ecc-5236-4cea-8cc5-ad26e5469665
Fixes #15912